<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118849/">https://git.reviewboard.kde.org/r/118849/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 20th, 2014, 2:56 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this could maybe fix
https://bugs.kde.org/show_bug.cgi?id=336070
but i'm a bit on the fence.
To me kida seems that to be really "correct", one would allow either manually resizing popups xor allowing applets to resize themselves, the two things seems kinda exclusive.
the only thing that would work in both cases is applets setting their minimum and maximum size, this that should work correctly now, regardless of saved size.
to me either way is fine, i wasn't an huge fan of manual popup resizing, but if this is removed could be considered that could be to never return, since would make applets to assume they are the sole in charge of the resize of the popup</pre>
</blockquote>
<p>On June 20th, 2014, 3:07 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we should make those dialogs resizable again, but then we need to think it through, for example only trying to set the size on load and storing it only when the user changed the size.
That can be a good feature to get in 5.1, for the moment we can remove the code that resizes to a setting nobody meant to save.
+1 to the patch.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So, ship it?
As Aleix says, we do need manual resizing as well. But I don't think we're going to get that into 5.0.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On June 20th, 2014, 2:35 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 20, 2014, 2:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> The popup dialog can currently never be resized, so it doesn't make
sense to record its height in a config file. Additionally, this also
causes problems when applet writers change the size of their plasmoid.
Since the old size is saved in the config file, it is shown with the old
dimensions instead of the new ones.
When we implement dialog resizing at that time we can propogate a signal which says that the applet has been manually resized and save it in a config file. Though even that could be buggy since the plasmoid could later be much smaller.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/appletquickitem.cpp <span style="color: grey">(a6e91f7)</span></li>
<li>src/plasmaquick/private/appletquickitem_p.h <span style="color: grey">(8b8010a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118849/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>