<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118636/">https://git.reviewboard.kde.org/r/118636/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in the end this causes massive issues on startup - kdeinit blocks as it waits on PA, which i guess is tried to initialize too early. meaning the whole startup is 'freezed' (you can interact with shell, but everything else is kapput) until the timeout is done/PA process is killed. another sideeffect is that it makes ksplash last for inappropriate amount of time (bug 336396). local revert resolved those problems completely here. note, i have sound notifications off, and haven't enabled plasma_workspace notifications</pre>
<br />
<p>- Hrvoje Senjan</p>
<br />
<p>On June 13th, 2014, 5:42 p.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Àlex Fiestas.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 13, 2014, 5:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335948">335948</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This returns the feature of having and configuring login/logout sounds for workspace; default remains off for both.
Additionally to this, I've made KNotification close immediately if there are no actions defined for the given event, so it won't even try (and wait for) all the notify plugins.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/CMakeLists.txt <span style="color: grey">(71ad4fc)</span></li>
<li>ksmserver/plasma_workspace.notifyrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/server.h <span style="color: grey">(f813394)</span></li>
<li>ksmserver/shutdown.cpp <span style="color: grey">(6a6dca9)</span></li>
<li>ksmserver/startup.cpp <span style="color: grey">(6f5d502)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118636/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>