<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118662/">https://git.reviewboard.kde.org/r/118662/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6099e02691c19f9deb47f307ec4f629848dbf2a3 by Harald Sitter to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 11th, 2014, 8:51 a.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated June 11, 2014, 8:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">${PLUGIN_INSTALL_DIR} already contains /plugins so appending it manually leads to /plugins/plugins/ as dir
dpkg -L project-neon5-plasma-workspace |grep phonon
/opt/project-neon5/lib/x86_64-linux-gnu/plugins/plugins/phonon_platform
/opt/project-neon5/lib/x86_64-linux-gnu/plugins/plugins/phonon_platform/kde.so
/opt/project-neon5/share/knotifications5/phonon.notifyrc
/opt/project-neon5/share/kservicetypes5/phononbackend.desktop
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds and installs without having /plugins/ twice in the target path</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>phonon/platform_kde/CMakeLists.txt <span style="color: grey">(a42c213ad212631079cf0d03a7f8cb9f4b1278d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118662/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>