<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118793/">https://git.reviewboard.kde.org/r/118793/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Elias Probst.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Drop old display KCM in favor of kscreen's KCM.
The old display KCM
- doesn't seem to work anymore (shows only a gray empty window)
- is not included in 'System Settings' anymore
- still shows up in search results (krunner, milou, ...)
- is superseded by kscreen</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Building plasma-desktop with this patch doesn't install these files anymore:
/usr/share/kservices5/display.desktop
/usr/lib64/plugins/kcm_display.so
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/hardware/CMakeLists.txt <span style="color: grey">(ab222935903f2c10562e4a74f7933bf694d6e818)</span></li>
<li>kcms/hardware/display/CMakeLists.txt <span style="color: grey">(ab8225f13ecf1623a6de28d20b467ecd306a368b)</span></li>
<li>kcms/hardware/display/Messages.sh <span style="color: grey">(561ccd0d8b2167dda6c354cff924166806c176ce)</span></li>
<li>kcms/hardware/display/display.cpp <span style="color: grey">(a0392821f80081bb1c6dc2e38af0a7acd41dcfd8)</span></li>
<li>kcms/hardware/display/display.desktop <span style="color: grey">(e8eff615aee5a27651ae56da909f3ecc2db09781)</span></li>
<li>kcms/hardware/display/display.h <span style="color: grey">(7e0c342240eb3559c555c2ea6635987fa18f7ba6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118793/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>