<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118512/">https://git.reviewboard.kde.org/r/118512/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Jonathan Riddell and Vishesh Handa.</div>
<div>By Matthew Dawson.</div>
<p style="color: grey;"><i>Updated June 16, 2014, 5:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.gentoo.org/show_bug.cgi?id=512334">https://bugs.gentoo.org/show_bug.cgi?id=512334</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Turn KFileMetaData into a Framework.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested compiling Baloo against a system install with this patch applied. Baloo sucessfully linked against the KF5 version and all Baloo tests ran to completion.
All KFileMetaData unit tests passed too ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/typeinfo.h <span style="color: grey">(2675cbbd5751de9a7ac77cf9fdda4cb6d0a7806e)</span></li>
<li>src/propertyinfo.h <span style="color: grey">(bb54f58c750eff8c39685861a5346c025265949b)</span></li>
<li>src/extractors/CMakeLists.txt <span style="color: grey">(0099c0878315a07f4d7b1369dc1471a8401f10a7)</span></li>
<li>src/extractorpluginmanager.h <span style="color: grey">(d4a871e7d5952edb48c5836769741d7cf20bd29f)</span></li>
<li>src/extractorplugin.h <span style="color: grey">(218ef207982e31f0142983d75b4846cd0f45f02a)</span></li>
<li>src/extractionresult.h <span style="color: grey">(76dfe590aaf1f1fda265a4835fa1bcdbc81ba58a)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(82dbd5c32050081642e9fff958d229f55893d40c)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(c657a7002d1d0644d6de4438a193bb63657b7ec0)</span></li>
<li>KFileMetaDataConfig.cmake.in <span style="color: grey">(b4d1c93b7a23ffcbb03a89e9d4a11559d7e22037)</span></li>
<li>KF5FileMetaDataConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(5a9eefa89b2fc7e6202347daf105baa867328ffc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118512/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>