<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118769/">https://git.reviewboard.kde.org/r/118769/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 60ddc9f25d75686b56145120096fa741b2b2216f by Kai Uwe Broulik to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 15th, 2014, 7:19 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, David Edmundson, Elias Probst, and Jan Grulich.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated June 15, 2014, 7:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311799">311799</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=336274">336274</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use RotationAnimator [1] for the BusyIndicator animation which operates directly on the scenegraph.
This helped reducing the massive plasmashell CPU usage during file copying (ie. notifications spinning). The results varied greatly but it can't hurt to use the Animator nonetheless since it doesn't propagate the new rotation angle constantly.
[1] http://qt-project.org/doc/qt-5/qml-qtquick-rotationanimator.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Put notification in panel and systray, requested a view from JobViewServer, ran top. Tried with different configurations, such as LIBGL_ALWAYS_SOFTWARE=1 or QML_FORCE_THREADED_RENDERER=1. Results varied but generally indicated a CPU relief.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qml/BusyIndicator.qml <span style="color: grey">(fafd031)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118769/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>