<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118730/">https://git.reviewboard.kde.org/r/118730/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 13th, 2014, 3:14 p.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand where this is useful unless you have a broken setup to begin with.
Either you have your XDG paths set up properly for all users at which point you don't need this.
Or you have DBus setup to load apps with a missing env, which is clearly a silly thing to do.
This patch will make things to work in the Plasma 5 env; but it'll still be broken if you ran this from other desktops which makes the setup wrong.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I don't understand where this is useful unless you have a broken setup to begin with.
I have to disagree. We set quite a lot of stuff in startkde which won't be picked up by DBus, e.g. XCURSOR_THEME. This results in for example the ktp chat window having a different cursor than everything else (I reported this bug to you ;-) ).</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 13th, 2014, 3:01 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 13, 2014, 3:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[startkde] Introduce a ksyncdbusenv helper application
This application is invoked by startkde once all environment variables
are set and syncs them to DBus for the activation environment.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">on log in kglobalacceld5 doesn't pick up the right environment yet, but on manual invocation of the tool + trigger restart of kglobalacceld5 it works. So the approach seems to work, just not yet from startkde (maybe it's too late?)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/CMakeLists.txt <span style="color: grey">(3360a1c59409588ecec49e63276914b69568164e)</span></li>
<li>startkde/ksyncdbusenv/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>startkde/ksyncdbusenv/ksyncdbusenv.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>startkde/startkde.cmake <span style="color: grey">(0c1f5841eeefc1012dbdc71e1d1fde11e7511dd6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118730/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>