<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118694/">https://git.reviewboard.kde.org/r/118694/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4889a12629520f542ec01785f75ad190846a7d4f by Martin Gräßlin to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 12th, 2014, 11:32 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 12, 2014, 11:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">X11/XCB becomes a required component
So far plasma-desktop supported to be built without X11 support (Win32),
but that was completely broken (X11Extras was required). Based on
discussion in [1] X11/XCB becomes a required component.
This means that we should not have any components in the build system
which are built optionaly depending on whether X11 is available. Ifdefs
in the code should stay, though.
For the future we will turn X11 in a optional dependency again. But it
will never be that a component won't be built if we are building without
X11. Instead there will be a required Wayland backend and this means all
X11 specific code needs to become platform aware.
So the way forward is:
1. X11 required
2. X11 required, Wayland optional
3. X11 required, Wayland required
4. Wayland required, X11 optional
[1] https://mail.kde.org/pipermail/plasma-devel/2014-June/032259.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(399de771e17b265c1e5a223ad128ae2d17c00d22)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(a5f35f77aead140054696ca4b3122fb177c70f1d)</span></li>
<li>kcms/CMakeLists.txt <span style="color: grey">(8024367f52b4fd3f757d4e5c5c851a204f4fd74b)</span></li>
<li>kcms/componentchooser/CMakeLists.txt <span style="color: grey">(66f0fece8b786cf277cf41e6bef0cf03b3f619d1)</span></li>
<li>kcms/componentchooser/componentservices/CMakeLists.txt <span style="color: grey">(15cca45a12e2e61c721f092b26fa5953701ee958)</span></li>
<li>kcms/style/CMakeLists.txt <span style="color: grey">(423241b8127491853d8afa75bb8b5d78c9009dca)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118694/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>