<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115431/">https://git.reviewboard.kde.org/r/115431/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 11th, 2014, 6:18 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested this out a bit today... and it didn't seem to work all that well. Did seem to result in too much whitespace at times, and was fairly easy to get plasma into a state where it would endlessly try to resize things to fit. Helped a bit to reduce my "small" font in systemsettings to something smaller, but the code really ought to be more robust against that situation.</pre>
</blockquote>
<p>On June 11th, 2014, 6:22 p.m. UTC, <b>Yichao Zhou</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you give a screenshot and the font name so I can give some help?</pre>
</blockquote>
<p>On June 11th, 2014, 6:23 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My testing and resizing resulted was primarily when using the digital clock's show "long date" option, sorry I failed to mention that.</pre>
</blockquote>
<p>On June 11th, 2014, 6:28 p.m. UTC, <b>Yichao Zhou</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK. Long date seems to have some problems on my system: space at top and bottom is not even. Is that you problem? Also, it will be better if you could provide a screenshot. Still, please provide your font name...</pre>
</blockquote>
<p>On June 11th, 2014, 6:36 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The top/bottom spacing isn't pleasing sometimes, indeed, but I could live with that.
I've tested with both Dejavu Sans and (google) Arimo fonts. The main problem I'm worried about is adjusting panel height sometimes results in the clock applet continually redrawing/resizing/reformatting itself to fit (something a screenshot cannot capture).</pre>
</blockquote>
<p>On June 11th, 2014, 6:53 p.m. UTC, <b>Yichao Zhou</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's strange. This patch does not modifiy the redraw mechanism of the widget. It just changes the method of calculating the width of text, i.e. using 00:00:00 get the width. Are you sure this does not happen before this patch? I just cannot reproduce your problem...
Maybe you can provide a video to demonstrate this problem. However, I just suspect whether the developer still interests in merging this patch since they seems to be busy with KDE5, which uses a completely different applet system.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested before and after the patch a bunch. Indeed it was possible before, but much harder (and rare). I suspect it's due to the added support for float point size increments instead of int.</pre>
<br />
<p>- Rex</p>
<br />
<p>On March 18th, 2014, 12:56 p.m. UTC, Yichao Zhou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yichao Zhou.</div>
<p style="color: grey;"><i>Updated March 18, 2014, 12:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=228902">228902</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For bug, see
https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and
https://bugs.kde.org/show_bug.cgi?id=228902
The problem is that in original code, it always uses 23:59 to calculate the width of the text. However, in some font, AM is wider than PM, and 0 is wider than 2 and 5. That causes some fonts been cropped.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/digital-clock/clock.cpp <span style="color: grey">(f26e328)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115431/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>