<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118678/">https://git.reviewboard.kde.org/r/118678/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 11th, 2014, 11:09 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can I check I'm understanding the objective.
For the language KCM we want to list all possible languages. Potentially systemsettings isn't translated so won't be listed. In order to get round this we need to pick a random other component that we can assume is translated in order to list all possible languages?
If so we could just do:
QStringList localeDirPaths = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation,
QString::fromLatin1("locale"),
QStandardPaths::LocateDirectory);
foreach (const QString &localDirPath, localeDirPaths) {
languages << localeDir.entryList(QDir::AllDirs);
}
which is what kcatalog is doing internally and will list everything.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, after looking a bit further: I don't think we really need this. For systemsettings, it makes sense to check whether systemsettings is translated, which is a good indicator for an available translation of the workspace. That makes the use-case for this patch academic, but not needed, so I'll simply drop this RR.
Thanks for the review, though!</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On June 11th, 2014, 10:09 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Chusslove Illich and John Layt.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated June 11, 2014, 10:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow querying for translations of a specific domain
In the new translations KCM, we want to list available languages for the
workspace. This might, or might not be the same application domain as
the one set (current translation is different from installed
translations). In order to list the installed translations, we need to
specify that domain, independently from the one set in
KLocalizedString's global static.
With this patch, I can successfully list installed languages in the new KCM.
I'm not super-familiar with how this stuff works, there might be a better way,
in which case I'm sure you guys will enlighten me. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested new translations KCM, languages show up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcatalog.cpp <span style="color: grey">(7711e9b261fc30d8faa355af9014d320275463a5)</span></li>
<li>src/klocalizedstring.h <span style="color: grey">(1a9fce8abcafcc8be0a2601c9062c33509dd403e)</span></li>
<li>src/klocalizedstring.cpp <span style="color: grey">(e12d6dfa9c147ffb127f462dc5db236be0d2ff75)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118678/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>