<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118548/">https://git.reviewboard.kde.org/r/118548/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1f5225d4405df26732fbc22ae1491614bc3a7420 by Aleix Pol to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 5th, 2014, 4:57 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Martin Gräßlin, Eike Hein, and Luca Beltrame.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 5, 2014, 4:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasmoid.screen doesn't map to QDesktopWidget indexes anymore, therefore we need to port it.
This patch uses the screen geometry to figure out what's the screen and then passes around the screen rect so that we can filter out the screens that aren't inside if the user asks for it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have played with it and seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libtaskmanager/taskmanager.cpp <span style="color: grey">(27eeed7)</span></li>
<li>libtaskmanager/taskmanager.h <span style="color: grey">(e6ca735)</span></li>
<li>libtaskmanager/task.h <span style="color: grey">(13a5a9c)</span></li>
<li>libtaskmanager/task.cpp <span style="color: grey">(50ea1a6)</span></li>
<li>libtaskmanager/launcheritem.cpp <span style="color: grey">(649caca)</span></li>
<li>libtaskmanager/groupmanager.h <span style="color: grey">(aa71bac)</span></li>
<li>libtaskmanager/groupmanager.cpp <span style="color: grey">(83b39ef)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118548/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>