<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118406/">https://git.reviewboard.kde.org/r/118406/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Usability review:
Since I lack the skills to picture it from the diff: When exactly is the notification shown? Is it shown as soon as the media is supposed to be played? If so, I think it could be done in a more subtle way: Grey out the entry in the playlist and just skip over it to the next entry int he playlist (like Amarok does) and show the message in a tooltip on mouseover on a pointer device or on tap on a touch device.
If it's already done in a similar way, then it's fine for me ;)</pre>
<br />
<p>- Thomas Pfeiffer</p>
<br />
<p>On June 3rd, 2014, 5:05 p.m. UTC, R.Harish Navnit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By R.Harish Navnit.</div>
<p style="color: grey;"><i>Updated June 3, 2014, 5:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333764">333764</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If a media(in a playlist) is located in an inaccessible location, then the user is notified about the same. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Load media to a playlist.
2. Unmount the device containing media.
3. Check if the user is notified of the location being inaccessible
--yes, the user is notified
4. Mount the device containing media and play a media from playlist.
-- The media plays properly.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediaplayer/MediaPlayer.qml <span style="color: grey">(98f1d2c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118406/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>