<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118516/">https://git.reviewboard.kde.org/r/118516/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2014, 1:02 p.m. CEST, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How would you connect to a VPN in that case?</pre>
</blockquote>
<p>On June 4th, 2014, 1:19 p.m. CEST, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)</pre>
</blockquote>
<p>On June 4th, 2014, 1:20 p.m. CEST, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.
I can't think of any other features using this.</pre>
</blockquote>
<p>On June 4th, 2014, 1:28 p.m. CEST, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, if it's started on demand (can you confirm that?) then means the applet is useful without networkmanager running, so the dbus activation doesn't apply there.</pre>
</blockquote>
<p>On June 4th, 2014, 1:39 p.m. CEST, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've never seen the NetworkManager process (and thus its dbus interface) being started on demand by activating a connection. (Doesn't mean it does, just that my use-cases are different, and it deserves a second look). The applet bails out with an error if NetworkManager isn't started, it won't list anything (not even VPN connections) in that case.
The approach to load it on-demand seems fine to me.</pre>
</blockquote>
<p>On June 4th, 2014, 1:54 p.m. CEST, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can use VPN connections without NetworkManager and I think that this patch makes sense, because plasma-nm is useless when NetworkManager is running.</pre>
</blockquote>
<p>On June 4th, 2014, 2:16 p.m. CEST, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So I pushed it for now. IF it causes problems can always be reverted</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems is not working as expected (here at least)
i have org.freedesktop.NetworkManager at system bus, but applet isn't loaded</pre>
<br />
<p>- Hrvoje</p>
<br />
<p>On June 4th, 2014, 2:13 p.m. CEST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 2:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/metadata.desktop <span style="color: grey">(7eafa44)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118516/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>