<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118512/">https://git.reviewboard.kde.org/r/118512/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Jonathan Riddell and Vishesh Handa.</div>
<div>By Matthew Dawson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.gentoo.org/show_bug.cgi?id=512334">https://bugs.gentoo.org/show_bug.cgi?id=512334</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've posted this RR as an RFC about the general structure of this idea. I just choose KFileMetaData as that is what my package manager conflicted over first. Ideally I want to push this change to any needed repositories for Plasma Next.
As far as I understand the ability for Plasma Next and KDE4 application to be co-installed, all libraries should be co-installable except as listed on this page: http://community.kde.org/Plasma/Coinstallability . However, on source based distributions, such as Gentoo, to have both the KDE4 and KF5 versions simultaneously installed requires that the development files are also co-installable. As mentioned on this Gentoo bug[1], the header files are trivially dealt with, and the library simlink will probably be a downstream specific solution (as CMake doesn't require it for compiling). However, the CMake configuration files are another matter. This is take one of trying to fix this issue. If a different naming scheme, or if some different CMake trickery is desired I'll see about changing things to that, otherwise I think this is the simple and easy solution.
I also volunteer to go through all the dependent packages and have patches ready (as best as I am able), as well as fix up any build failures that occur due to this change. Only find_package calls need modification, targets are left alone.
[1] https://bugs.gentoo.org/show_bug.cgi?id=512334</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested compiling Baloo against a system install with this patch applied. Baloo sucessfully linked against the KF5 version and all Baloo tests ran to completion.
All KFileMetaData unit tests passed too ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(82dbd5c32050081642e9fff958d229f55893d40c)</span></li>
<li>KFileMetaDataConfig.cmake.in <span style="color: grey">(b4d1c93b7a23ffcbb03a89e9d4a11559d7e22037)</span></li>
<li>CMakeLists.txt <span style="color: grey">(aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118512/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>