<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118506/">https://git.reviewboard.kde.org/r/118506/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 45233b0fc9bc2529c5acbb04d4501bec3f283476 by Antonis Tsiapaliokas to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 4th, 2014, 11:30 a.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 11:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a new UI for image package on the Plasma Active.
In order to test it you can use "PLASMA_PLATFORM=touch plasmashell -p org.kde.plasma.active".
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything looks normal except from the "dotRow".
Despite the fact that the "dotRow" changes, the view of the ListView remains the same.
So you cannot see the rest of the wallpapers.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>wallpapers/image/backgroundlistmodel.h <span style="color: grey">(64417a3)</span></li>
<li>wallpapers/image/backgroundlistmodel.cpp <span style="color: grey">(439c642)</span></li>
<li>wallpapers/image/imagepackage/platformcontents/touch/ui/WallpaperDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpapers/image/imagepackage/platformcontents/touch/ui/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpapers/image/imageplugin.cpp <span style="color: grey">(876fd8d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118506/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/03/06ef2797-b119-43c6-a4db-0bde63f674c5__wallapers_active.png">wallpaper_with_dotRow</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/03/124bdfd6-649e-4bb2-9786-3a7723acd576__wallapers_active_fullscreen.png">wallpapers_without_dotRow</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>