<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118038/">https://git.reviewboard.kde.org/r/118038/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Small issue in the Comment of the .desktop file, otherwise, it's good to go in.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118038/diff/3/?file=277686#file277686line13" style="color: black; font-weight: bold; text-decoration: underline;">ksmserver/screenlocker/kcm/screenlocker.desktop</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Comment=Configure the lock screen</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Screen Locking Timeouts
... please. :)</pre>
</div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On June 3rd, 2014, 6:53 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Thomas Pfeiffer.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 3, 2014, 6:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bring back a KCM for the screen locker
Together with adding back the KCM the settings are slightly adjusted to
have them fit the UI without needing a transformation in the KCM.
* timeout is stored in minutes (used to be seconds)
* grace time is stored in seconds (used to be msec)
* lock is enabled by default
Also disabling the locking after idle timeout is no longer possible. An
endless grace made some sense with the screensavers, but not with the
screenlocker. In order to not break an unknown but maybe valid use case
the option is still available, just not exposed through UI.
REVIEW: 118038</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: grey">(486563720cfd9af59f1ae2f06a0b9ff4a3c96ea8)</span></li>
<li>ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg <span style="color: grey">(18a12935e127aad75fcf72213f8e34c25a8ed16c)</span></li>
<li>ksmserver/screenlocker/kcm/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/screenlocker.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(eff9d8d7d7a661a2eac9bf76196380816951bd7a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118038/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png">KCM with values</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png">KCM without values</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/65025e3c-30d1-4d91-8173-314fecb39241__kcm-in-systemsettings.png">In Systemsettings</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>