<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118469/">https://git.reviewboard.kde.org/r/118469/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also, loses the window shadows (would need duplication of other classes that are not going to be exported)
I see that it pretty much causes duplication of a ton of codethat is not public and not scheduled to ever be public.
Flickers and excess of repaints are a bug that has to be fixed upstream, not worked around with that that is effectively a fork of an huge quantity of code.</pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On June 2nd, 2014, 1:15 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 2, 2014, 1:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> KRunner: Stop using the dialog class
The dialog class provides a number of features such as resizing itself
when the item size changes, vice versa, and has slightly complex logic
to handle to being a tooltip / dialog / etc. We do not really need any
of this logic. We're just a simple window with a item + border.
This removes the duplicated dialog.h header file, but it unfortunately
introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
should be a temporary copy until these files are exported properly.
This patch fixes all the annoying flickering issues with krunner and
makes it much much smoother. It also fixes issues where the top border
is initially present but later disappears.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is much much smoother, and the number of repaints/resizes are much less. Tested by comparing frames via apitrace.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/view.h <span style="color: grey">(fe7fa1c)</span></li>
<li>krunner/units.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/units.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/svgtexturenode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/framesvgitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/view.cpp <span style="color: grey">(8e1b448)</span></li>
<li>krunner/framesvgitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/dialog.h <span style="color: grey">(6759a6e)</span></li>
<li>krunner/CMakeLists.txt <span style="color: grey">(c7dbd71)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118469/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png">KRunner + Dialog Class</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png">KRunner without dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>