<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118469/">https://git.reviewboard.kde.org/r/118469/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118469/diff/1/?file=277433#file277433line85" style="color: black; font-weight: bold; text-decoration: underline;">krunner/view.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">84</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Border Frame</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you really can't fix dialog create a tiny QML file with the contents
import org.kde.plasmacore 2.0
FrameSvgItem {
svg:...
anchors.fill: parent
}
then do a setSource(myQMLFile.qml)
that way you won't need to clone half the world to load an.</pre>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On June 2nd, 2014, 1:15 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 2, 2014, 1:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> KRunner: Stop using the dialog class
The dialog class provides a number of features such as resizing itself
when the item size changes, vice versa, and has slightly complex logic
to handle to being a tooltip / dialog / etc. We do not really need any
of this logic. We're just a simple window with a item + border.
This removes the duplicated dialog.h header file, but it unfortunately
introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
should be a temporary copy until these files are exported properly.
This patch fixes all the annoying flickering issues with krunner and
makes it much much smoother. It also fixes issues where the top border
is initially present but later disappears.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is much much smoother, and the number of repaints/resizes are much less. Tested by comparing frames via apitrace.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/view.h <span style="color: grey">(fe7fa1c)</span></li>
<li>krunner/units.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/units.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/svgtexturenode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/framesvgitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/view.cpp <span style="color: grey">(8e1b448)</span></li>
<li>krunner/framesvgitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krunner/dialog.h <span style="color: grey">(6759a6e)</span></li>
<li>krunner/CMakeLists.txt <span style="color: grey">(c7dbd71)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118469/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png">KRunner + Dialog Class</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png">KRunner without dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>