<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118346/">https://git.reviewboard.kde.org/r/118346/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 27th, 2014, 12:08 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">at the moment this cannot be enabled yet. I have already prepared a similar change and backed away from it, due to no way to figure out whether prison is compiled against Qt4 or Qt5.
Further more on Debian based systems the installation of prison for Qt5 is broken, see https://git.reviewboard.kde.org/r/118291/
This results in the system's prison installation being used and completely breaking klipper. To solve this I added a version check in my variant, but that's of course also incomplete.</pre>
</blockquote>
<p>On May 27th, 2014, 12:25 p.m. CEST, <b>Johannes Huber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems debian/ubuntu specific problem. Works here on Gentoo with prison qt5 build. As this is a optional build option it can be easily disabled downstream.
* Contents of media-libs/prison-9999:
/usr
/usr/include
/usr/include/prison
/usr/include/prison/AbstractBarcode
/usr/include/prison/BarcodeItem
/usr/include/prison/BarcodeWidget
/usr/include/prison/Code39Barcode
/usr/include/prison/Code93Barcode
/usr/include/prison/DataMatrixBarcode
/usr/include/prison/QRCodeBarcode
/usr/include/prison/abstractbarcode.h
/usr/include/prison/barcodeitem.h
/usr/include/prison/barcodewidget.h
/usr/include/prison/code39barcode.h
/usr/include/prison/code93barcode.h
/usr/include/prison/datamatrixbarcode.h
/usr/include/prison/prison_export.h
/usr/include/prison/qrcodebarcode.h
/usr/lib
/usr/lib/debug
/usr/lib/debug/usr
/usr/lib/debug/usr/lib64
/usr/lib/debug/usr/lib64/libprison.so.0.2.0.debug
/usr/lib64
/usr/lib64/cmake
/usr/lib64/cmake/Prison
/usr/lib64/cmake/Prison/PrisonConfig.cmake
/usr/lib64/cmake/Prison/PrisonConfigVersion.cmake
/usr/lib64/libprison.so -> libprison.so.0
/usr/lib64/libprison.so.0 -> libprison.so.0.2.0
/usr/lib64/libprison.so.0.2.0
</pre>
</blockquote>
<p>On May 27th, 2014, 12:32 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">and what happens if you have both prison for qt4 and qt5 installed? This looks to me like you only have one install of prison.
I run into this issue on Saturday resulting in the linked review request. To me it looks like prison for Qt 5 has not yet reached a quality that allows it as a dependency.
Of course it's an optional dependency and can be easily disabled. But it means that anybody not yet having prison/qt5, but having a prison/qt4 will have picked it up automatically and thus breaking klipper. As long as prison doesn't fix that, it's a -2 to me. It's easy to fix in prison: just use a new version number for the Qt5 build.</pre>
</blockquote>
<p>On May 27th, 2014, 1:02 p.m. CEST, <b>Johannes Huber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> and what happens if you have both prison for qt4 and qt5 installed?
* package media-libs/prison-1.1.1 NOT merged
*
* Detected file collision(s):
*
* /usr/include/prison/prison_export.h
* /usr/include/prison/QRCodeBarcode
* /usr/include/prison/qrcodebarcode.h
* /usr/include/prison/DataMatrixBarcode
* /usr/include/prison/datamatrixbarcode.h
* /usr/include/prison/Code93Barcode
* /usr/include/prison/code93barcode.h
* /usr/include/prison/Code39Barcode
* /usr/include/prison/code39barcode.h
* /usr/include/prison/BarcodeWidget
* /usr/include/prison/barcodewidget.h
* /usr/include/prison/BarcodeItem
* /usr/include/prison/barcodeitem.h
* /usr/include/prison/AbstractBarcode
* /usr/include/prison/abstractbarcode.h
* /usr/lib64/cmake/Prison/PrisonConfig.cmake
* /usr/lib64/libprison.so
* /usr/lib64/libprison.so.0
With the current build system of prison it isn't possible to install prison qt4/qt5 in parallel.
</pre>
</blockquote>
<p>On May 27th, 2014, 1:30 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> With the current build system of prison it isn't possible to install prison qt4/qt5 in parallel.
sorry, but we get side tracked. The issue is that if Qt 4 version is installed, but not the Qt 5 version, the Qt 4 version gets picked and breaks klipper.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes thats an downstream packaging issue of defining the correct version.</pre>
<br />
<p>- Johannes</p>
<br />
<p>On May 27th, 2014, 11:37 a.m. CEST, Johannes Huber wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Johannes Huber.</div>
<p style="color: grey;"><i>Updated May 27, 2014, 11:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build option is needed to have prison support.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled with and without prison support. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/CMakeLists.txt <span style="color: grey">(c700f9e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118346/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>