<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118209/">https://git.reviewboard.kde.org/r/118209/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On May 19th, 2014, 7:48 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/118209/diff/1/?file=273524#file273524line10" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/favicons/CMakeLists.txt</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="s">Qt5::Gui</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems more like KF5::Plasma needs to publicly link against Qt5:Gui</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Will create another RR for this and then drop this.</pre>
<br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On May 19th, 2014, 7:48 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/118209/diff/1/?file=273526#file273526line33" style="color: black; font-weight: bold; text-decoration: underline;">runners/calculator/CMakeLists.txt</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
    <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                          <span class="s">Qt5::Script</span></pre></td>
    <th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why this?</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorted the list alphabetically when I wrongly placed Qt5::Gui there before and then removed it again, so the result is just a changed (alphabetically) order of the Qt:: components.</pre>
<br />




<p>- Elias</p>


<br />
<p>On May 19th, 2014, 7:39 p.m. UTC, Elias Probst wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Elias Probst.</div>


<p style="color: grey;"><i>Updated May 19, 2014, 7:39 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasma-workspace fails to build as several components can't find Qt5 component headers:

79b4614 Fix build (not finding QIcon from Qt5::Gui).
dataengines/share/CMakeLists.txt

32e021a Fix build (not finding QImage from Qt5::Gui).
dataengines/favicons/CMakeLists.txt

321445c Fix build (not finding QApplication from Qt5::Widgets).
dataengines/activities/CMakeLists.txt

1d34cd5 Fix build (not finding QIcon from Qt5::Gui).
runners/calculator/CMakeLists.txt

8a4edd3 Fix build (not finding QApplication from Qt5::Widgets).
containmentactions/paste/CMakeLists.txt

8dc9d9e Cleaned up indentation/trailing whitespace.
containmentactions/paste/CMakeLists.txt

3dc1e3e Fix build (not finding QGuiApplication from Qt5::Gui).
containmentactions/paste/CMakeLists.txt

39df7b3 Fix build (not finding QApplication from Qt5::Widgets).
containmentactions/switchactivity/CMakeLists.txt
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasma-workspace built successfully again.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>containmentactions/paste/CMakeLists.txt <span style="color: grey">(afcd2d4149f58ac6c92f996e8e2f3343ed914a64)</span></li>

 <li>containmentactions/switchactivity/CMakeLists.txt <span style="color: grey">(90d68980af88a74c1063493393bfaece7490a770)</span></li>

 <li>dataengines/activities/CMakeLists.txt <span style="color: grey">(c1159e1d09be20e9f02704fddb7dbc120c3871c5)</span></li>

 <li>dataengines/favicons/CMakeLists.txt <span style="color: grey">(e1fa3aeb2fd97445fc1ce3992be27aba00d8a0fc)</span></li>

 <li>dataengines/share/CMakeLists.txt <span style="color: grey">(f7737bf7457d11fa8fcc3c651a172cb944239356)</span></li>

 <li>runners/calculator/CMakeLists.txt <span style="color: grey">(31f6fd43fe172e8d99c60a425f1ece23ff539f70)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118209/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>