<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118209/">https://git.reviewboard.kde.org/r/118209/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7b5e47c1e7612817889ea063ce84471f5e007be9 by Elias Probst to branch master.</pre>
 <br />









<p>- Commit Hook</p>


<br />
<p>On May 19th, 2014, 7:39 p.m. UTC, Elias Probst wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Elias Probst.</div>


<p style="color: grey;"><i>Updated May 19, 2014, 7:39 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasma-workspace fails to build as several components can't find Qt5 component headers:

79b4614 Fix build (not finding QIcon from Qt5::Gui).
dataengines/share/CMakeLists.txt

32e021a Fix build (not finding QImage from Qt5::Gui).
dataengines/favicons/CMakeLists.txt

321445c Fix build (not finding QApplication from Qt5::Widgets).
dataengines/activities/CMakeLists.txt

1d34cd5 Fix build (not finding QIcon from Qt5::Gui).
runners/calculator/CMakeLists.txt

8a4edd3 Fix build (not finding QApplication from Qt5::Widgets).
containmentactions/paste/CMakeLists.txt

8dc9d9e Cleaned up indentation/trailing whitespace.
containmentactions/paste/CMakeLists.txt

3dc1e3e Fix build (not finding QGuiApplication from Qt5::Gui).
containmentactions/paste/CMakeLists.txt

39df7b3 Fix build (not finding QApplication from Qt5::Widgets).
containmentactions/switchactivity/CMakeLists.txt
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasma-workspace built successfully again.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>containmentactions/paste/CMakeLists.txt <span style="color: grey">(afcd2d4149f58ac6c92f996e8e2f3343ed914a64)</span></li>

 <li>containmentactions/switchactivity/CMakeLists.txt <span style="color: grey">(90d68980af88a74c1063493393bfaece7490a770)</span></li>

 <li>dataengines/activities/CMakeLists.txt <span style="color: grey">(c1159e1d09be20e9f02704fddb7dbc120c3871c5)</span></li>

 <li>dataengines/favicons/CMakeLists.txt <span style="color: grey">(e1fa3aeb2fd97445fc1ce3992be27aba00d8a0fc)</span></li>

 <li>dataengines/share/CMakeLists.txt <span style="color: grey">(f7737bf7457d11fa8fcc3c651a172cb944239356)</span></li>

 <li>runners/calculator/CMakeLists.txt <span style="color: grey">(31f6fd43fe172e8d99c60a425f1ece23ff539f70)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118209/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>