<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118145/">https://git.reviewboard.kde.org/r/118145/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated May 15, 2014, 12:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this patch i am porting the activity swithcer. Below i am describing the stuff that i have changed.
*port mobilecomponents to QtQuick 2.2 and KF5
*move qmlpackages/activityswitcher to activeshellpackage
*move qmlpackages/contour-tablet-homescreen/contents/ui/ActivityPanel.qml to activeshellpackage.
*for the activityswithcer i am using the activity components in order to change/delete an activity</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Things that they don't work:
*if you try to delete an activity, the slidding panel is hidding,
before you are able to delete it.
*thumbnail can show the wallpaper only if it is not the default one.
*you cannot create an activity yet</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2672295)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ActivityBrowser.qml <span style="color: grey">(aa6b362)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ActivityCreationDialog.qml <span style="color: grey">(fc5ff78)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ActivityDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ActivityDeletionDialog.qml <span style="color: grey">(42197fa)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ActivityItem.qml <span style="color: grey">(fd22743)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ActivityList.qml <span style="color: grey">(712ca76)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ActivityManager.qml <span style="color: grey">(ca10713)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ActivityPanel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ConfirmationDialog.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ControlButton.qml <span style="color: grey">(1e9854f)</span></li>
<li>activeshellpackage/package/contents/activitymanager/Heading.qml <span style="color: grey">(ea0560e)</span></li>
<li>activeshellpackage/package/contents/activitymanager/StoppedActivityItem.qml <span style="color: grey">(c5dcb98)</span></li>
<li>activeshellpackage/package/contents/activitymanager/ToolBar.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>activeshellpackage/package/contents/activitymanager/WindowPreview.qml <span style="color: grey">(295a163)</span></li>
<li>activeshellpackage/package/contents/views/Desktop.qml <span style="color: grey">(67b13cf)</span></li>
<li>components/CMakeLists.txt <span style="color: grey">(0557d13)</span></li>
<li>components/mobilecomponents/ActionButton.qml <span style="color: grey">(53ff260)</span></li>
<li>components/mobilecomponents/CMakeLists.txt <span style="color: grey">(1f57975)</span></li>
<li>components/mobilecomponents/DatePicker.qml <span style="color: grey">(e9862b6)</span></li>
<li>components/mobilecomponents/IconButton.qml <span style="color: grey">(1b15305)</span></li>
<li>components/mobilecomponents/IconGrid.qml <span style="color: grey">(881fac1)</span></li>
<li>components/mobilecomponents/OverlayDrawer.qml <span style="color: grey">(9970e16)</span></li>
<li>components/mobilecomponents/Rating.qml <span style="color: grey">(477affd)</span></li>
<li>components/mobilecomponents/ResourceDelegate.qml <span style="color: grey">(bdef70d)</span></li>
<li>components/mobilecomponents/SplitDrawer.qml <span style="color: grey">(6bb9c60)</span></li>
<li>components/mobilecomponents/TimePicker.qml <span style="color: grey">(28f9c71)</span></li>
<li>components/mobilecomponents/ViewSearch.qml <span style="color: grey">(9e299b4)</span></li>
<li>components/mobilecomponents/fallbackcomponent.cpp <span style="color: grey">(10fb0a6)</span></li>
<li>components/mobilecomponents/mobilecomponentsplugin.h <span style="color: grey">(a7d8010)</span></li>
<li>components/mobilecomponents/mobilecomponentsplugin.cpp <span style="color: grey">(db91cad)</span></li>
<li>components/mobilecomponents/package.h <span style="color: grey">(506a0c3)</span></li>
<li>components/mobilecomponents/package.cpp <span style="color: grey">(2412b05)</span></li>
<li>components/mobilecomponents/pagedproxymodel.cpp <span style="color: grey">(f861d5b)</span></li>
<li>components/mobilecomponents/private/Digit.qml <span style="color: grey">(173adde)</span></li>
<li>components/mobilecomponents/qmldir <span style="color: grey">(18212b6)</span></li>
<li>components/mobilecomponents/resourcedelegates/Bookmark/Item.qml <span style="color: grey">(e653816)</span></li>
<li>components/mobilecomponents/resourcedelegates/Bookmark/ItemHorizontal.qml <span style="color: grey">(84e5e30)</span></li>
<li>components/mobilecomponents/resourcedelegates/FileDataObject/Item.qml <span style="color: grey">(3844b24)</span></li>
<li>components/mobilecomponents/resourcedelegates/FileDataObject/ItemHorizontal.qml <span style="color: grey">(ac03b55)</span></li>
<li>components/mobilecomponents/resourcedelegates/Image/Item.qml <span style="color: grey">(0e02c8f)</span></li>
<li>components/mobilecomponents/resourcedelegates/Image/ItemHorizontal.qml <span style="color: grey">(59b7f0c)</span></li>
<li>components/mobilecomponents/texteffects.h <span style="color: grey">(89a438d)</span></li>
<li>components/mobilecomponents/texteffects.cpp <span style="color: grey">(f24af9a)</span></li>
<li>components/settings/CMakeLists.txt <span style="color: grey">(d21a52d)</span></li>
<li>components/settings/configgroup.h <span style="color: grey">(f36511d)</span></li>
<li>components/settings/configgroup.cpp <span style="color: grey">(01e45e3)</span></li>
<li>components/settings/settingscomponent.h <span style="color: grey">(8d52a43)</span></li>
<li>components/settings/settingscomponent.cpp <span style="color: grey">(66a95a9)</span></li>
<li>components/settings/settingsmodulesmodel.h <span style="color: grey">(e2aff93)</span></li>
<li>components/settings/settingsmodulesmodel.cpp <span style="color: grey">(6b67398)</span></li>
<li>components/settings/settingsplugin.h <span style="color: grey">(fb18863)</span></li>
<li>qmlpackages/CMakeLists.txt <span style="color: grey">(7735195)</span></li>
<li>qmlpackages/activityswitcher/CMakeLists.txt <span style="color: grey">(7bb900e)</span></li>
<li>qmlpackages/activityswitcher/Messages.sh <span style="color: grey">(f329d2e)</span></li>
<li>qmlpackages/activityswitcher/contents/images/duplicate.svgz <span style="color: grey">(be68aba)</span></li>
<li>qmlpackages/activityswitcher/contents/images/emptyactivity.png <span style="color: grey">(73f2806)</span></li>
<li>qmlpackages/activityswitcher/contents/images/fanstack.svgz <span style="color: grey">(9b82491)</span></li>
<li>qmlpackages/activityswitcher/contents/images/filter.svgz <span style="color: grey">(66e3962)</span></li>
<li>qmlpackages/activityswitcher/contents/images/icons.svgz <span style="color: grey">(54fbbd0)</span></li>
<li>qmlpackages/activityswitcher/contents/images/organize.svgz <span style="color: grey">(2c45e1a)</span></li>
<li>qmlpackages/activityswitcher/contents/images/organize2.svgz <span style="color: grey">(0f9bf66)</span></li>
<li>qmlpackages/activityswitcher/contents/images/plus.svgz <span style="color: grey">(97af277)</span></li>
<li>qmlpackages/activityswitcher/contents/images/slider.png <span style="color: grey">(2ed9860)</span></li>
<li>qmlpackages/activityswitcher/contents/images/slider.svgz <span style="color: grey">(44721e2)</span></li>
<li>qmlpackages/activityswitcher/contents/images/sliderhole.png <span style="color: grey">(fcc34d2)</span></li>
<li>qmlpackages/activityswitcher/contents/images/trash.svgz <span style="color: grey">(4e2146b)</span></li>
<li>qmlpackages/activityswitcher/contents/ui/ActivityDelegate.qml <span style="color: grey">(4b68ec9)</span></li>
<li>qmlpackages/activityswitcher/contents/ui/ConfirmationDialog.qml <span style="color: grey">(d812316)</span></li>
<li>qmlpackages/activityswitcher/contents/ui/ToolBar.qml <span style="color: grey">(99b6d94)</span></li>
<li>qmlpackages/activityswitcher/contents/ui/config.ui <span style="color: grey">(e69de29)</span></li>
<li>qmlpackages/activityswitcher/contents/ui/main.qml <span style="color: grey">(d7a6ae1)</span></li>
<li>qmlpackages/activityswitcher/metadata.desktop <span style="color: grey">(e585073)</span></li>
<li>qmlpackages/contour-tablet-homescreen/contents/ui/ActivityPanel.qml <span style="color: grey">(da3a28a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118145/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>