<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118063/">https://git.reviewboard.kde.org/r/118063/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 10th, 2014, 9:52 p.m. BST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/118063/file/1248/" style="color: black; font-weight: bold; font-size: 9pt;">formatskcm.png</a>
<p>new Formats KCM in kcmshell5</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this be "Country" rather than Region?</pre>
</blockquote>
<p>On May 11th, 2014, 7:06 p.m. BST, <b>John Layt</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd stick with Region, the locale is a combination of country and language which usually applies in a region. Just ask our Catalan friends how they would feel about only having a single option for "Spain" :-) The alternative (as used in POSIX, Gnome, and Windows) is to list by language name first, e.g. "English (Great Britain)" but personally I prefer the country first in this case (as does Mac OSX).</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The one problem I do have with using "Region" is that it feels slightly inconsistent with the other combo labels which are "Numbers" "Time" etc</pre>
<br />
<p>- John</p>
<br />
<p>On May 9th, 2014, 5:05 p.m. BST, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and John Layt.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated May 9, 2014, 5:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=331930">331930</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The current "Locale" KCM is almost entirely broken. The way forward is to split it into localization options (this, Formats), and translaticons. This patch implements a new Formats KCM which writes out an environment suitable for QLocale to pick it up.
It's a rewrite of the current KCM, since:
- everything under the hood is different (KLocale is gone, QLocale takes over)
- everything above the hood is different, in QLocale, everything is deduced from the country / region
Now this includes feature regressions compared to the old KCM, but not all of these features can be done at all on top of QLocale right now, so we have to set up what we can.
This KCM caches the settings in a config file, but most importantly, it writes out a script with export instructions, which can be picked up by startkde. This is all done according to John's suggestions, and I have a patch for startkde to pick up the settings here. It all works fine (on my machine).
Many more details about the implementation can be found in the plasma-devel thead "Locale settings in Plasma Next", started by John on February, 23rd 2014.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried all kinds of different combinations, applied them, made sure they're exported correctly in the script.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/formats/kcmformatswidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/formats/kcmformats.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/formats/kcmformats.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/formats/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/formats/formats.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/formats/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/CMakeLists.txt <span style="color: grey">(ed86efa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118063/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/873980fe-04f2-4d75-9074-2aa676723061__formatskcm.png">new Formats KCM in kcmshell5</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskcmss.png">Formats KCM in systemsettings</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>