<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118061/">https://git.reviewboard.kde.org/r/118061/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok for now, should just change the name and location of the shell sources</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118061/diff/1/?file=272206#file272206line91" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"><span class="hl">#</span>add_subdirectory(qmlpackages)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_subdirectory</span><span class="p">(</span><span class="s">qmlpackages</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">leavethe qmlpackages folder alone, put "activeshellpackage" in the root</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118061/diff/1/?file=272229#file272229line2" style="color: black; font-weight: bold; text-decoration: underline;">qmlpackages/shell/package/contents/defaults</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Containment=org.kde.active.desktop</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you don't have a containment called this way yet, leave it desktop for now</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118061/diff/1/?file=272234#file272234line28" style="color: black; font-weight: bold; text-decoration: underline;">qmlpackages/shell/package/contents/loader.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">property</span> <span class="nx">string</span> <span class="k">shell :</span> <span class="s2">"org.kde.active.shell"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">org.kde.plasma.active</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118061/diff/1/?file=272237#file272237line18" style="color: black; font-weight: bold; text-decoration: underline;">qmlpackages/shell/package/metadata.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">X-KDE-PluginInfo-Name=org.kde.active.shell</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">name it org.kde.plasma.active</pre>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On May 9th, 2014, 2:05 p.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated May 9, 2014, 2:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a copy of desktop shell package but remove the stuff that we
don't need. Like the contextmenu, panelconfiguration and the toolbox
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>qmlpackages/shell/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/views/Panel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/views/Desktop.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/layout.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/loader.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/explorer/WidgetExplorer.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/explorer/Tooltip.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/explorer/AppletDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/defaults <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/configuration/MouseEventInputButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/configuration/ContainmentConfiguration.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/configuration/ConfigurationShortcuts.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/configuration/ConfigurationContainmentAppearance.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/configuration/ConfigurationContainmentActions.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/configuration/ConfigCategoryDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/configuration/AppletConfiguration.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/applet/DefaultCompactRepresentation.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/applet/CompactApplet.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/applet/AppletError.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/WindowPreview.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/StoppedActivityItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/Heading.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/ControlButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/ActivityManager.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/ActivityList.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/ActivityItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/ActivityDeletionDialog.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/ActivityCreationDialog.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/shell/package/contents/activitymanager/ActivityBrowser.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qmlpackages/CMakeLists.txt <span style="color: grey">(d277441)</span></li>
<li>CMakeLists.txt <span style="color: grey">(c7e3797)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118061/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>