<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118013/">https://git.reviewboard.kde.org/r/118013/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118013/diff/1/?file=271758#file271758line6" style="color: black; font-weight: bold; text-decoration: underline;">ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <kcfgfile name="kscreen<span class="hl">sav</span>errc" /></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <kcfgfile name="kscreen<span class="hl">lock</span>errc" /></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it's bit odd having an rc that is a different name to the .kcfg file</pre>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On May 6th, 2014, 10:37 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 6, 2014, 10:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[screenlocker/greeter] Drop code for GraphicsSceneMousePressEvent handling
It was used to ensure that the view which last got pressed on gets
keyboard events. This is no longer needed, after clicking a screen the
keyboard events end on the correct screen.
[screenlocker] Rename configuration file and config groups
It's not a screensaver anymore so not save into a config file and group
which would indicate so. Also introduce a dedicated group for the options
relevant only in the greeter.
[screenlocker] Drop Saver config option
It's not used anywhere in the code base.
[screenlocker] Drop PluginsUnlock and PluginOption configuration keys
Not used anywhere in the code base.
[screenlocker] Drop Priority configuration key
Not used in the code base.
[screenlocker] Drop the Action* configuration keys
Not used anywhere in the code base.
[screenlocker] Drop SuspendWhenInvisible configuration key
It's not used anywhere in the screenlocker.
[screenlocker] Drop config option ScreenSaverEnabled
* we don't have screen savers any more
* it's only used if timeout is larger than 0
Thus the timeout itself is good enough. To make sure the timeout value is
sane it got a min of 0.
[screenlocker] Drop unused greeter.h and greeter.cpp
It was from the old lock screen, no longer needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeter.h <span style="color: grey">(543efac6b4b5a28327646cebfec4e626d86ad906)</span></li>
<li>ksmserver/screenlocker/greeter/greeter.cpp <span style="color: grey">(e2eda9f77cfece06ce30547c0c91630502e10654)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(fa2e3442e911476cc2b995a343d10bba522ddca2)</span></li>
<li>ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg <span style="color: grey">(6a1cbb0935461c8045dd847a63e31e72fb6ca007)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(c678cfc33f82509776047894e46c4fbe15563d49)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118013/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>