<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118038/">https://git.reviewboard.kde.org/r/118038/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 7th, 2014, 9:31 p.m. CEST, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, usability review. Some recommendations, some questions:
- This right now only has these options because adding wallpapers or Plasmoids simply wasn't implemented yet and will get more settings once they are implemented, right?
- In which category will it reside? In 4.X it is in "Display & Monitor" and thus in the Hardware category, where it certainly should not be because it has nothing to do with hardware. It should go into workspace settings
- "Immediate" should say "Immediately"
- I think Sebas' suggestion to use comboboxes makes sense, but it would make even more sense to use editable comboboxes, which would combine the ease of selecting one of a few values with the flexibility of being able to enter an arbitrary number. What's saved in the config file would always be a number.
- Why is "Lock screen after" in minutes, but "Require password after" in seconds? Is it because it the latter is only supposed to be a grace time to allow users to move the mouse to prevent having to enter the password when they see the screen has locked?
- The GUI (just like the 4.x one) does not make clear whether "Require password after" means "After the last user action" or "After the screen was locked". I'd write "Require password after locking:". This is still not 100% clear, but should be more clear than it is now.
- Is "Logout automatically after" really useful? do we know of realistic usecases for this feature? Otherwise, I'd remove it.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> - This right now only has these options because adding wallpapers or Plasmoids simply wasn't implemented yet and will get more settings once they are implemented, right?
yes
> - In which category will it reside? In 4.X it is in "Display & Monitor" and thus in the Hardware category, where it certainly should not be because it has nothing to do with hardware. It should go into workspace settings
done
> - "Immediate" should say "Immediately"
done
> - Why is "Lock screen after" in minutes, but "Require password after" in seconds? Is it because it the latter is only supposed to be a grace time to allow users to move the mouse to prevent having to enter the password when they see the screen has locked?
yes. I followed the old KCM in that reguard
> - The GUI (just like the 4.x one) does not make clear whether "Require password after" means "After the last user action" or "After the screen was locked". I'd write "Require password after locking:". This is still not 100% clear, but should be more clear than it is now.
done
> - Is "Logout automatically after" really useful? do we know of realistic usecases for this feature? Otherwise, I'd remove it.
no idea whether it's useful. I can remove it from the UI as it wasn't in the old UI either. I wouldn't mind to remove the feature from the code base either ;-)</pre>
<br />
<p>- Martin</p>
<br />
<p>On May 7th, 2014, 5:17 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Thomas Pfeiffer.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 7, 2014, 5:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bring back a KCM for the screen locker
Note: I will improve the default values to get them sane. That needs adjustements in the screenlocker source base and I want to get the review of the UI started earlier.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: grey">(3407ea46d5046f2f5b2e7321d714ad1e65ffceea)</span></li>
<li>ksmserver/screenlocker/kcm/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/screenlocker.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118038/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png">KCM with values</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png">KCM without values</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>