<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118022/">https://git.reviewboard.kde.org/r/118022/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118022/diff/1/?file=271798#file271798line188" style="color: black; font-weight: bold; text-decoration: underline;">browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MetadataMusicBackend::handleButtonClick(const QString& buttonName)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">187</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//FIXME: This is a horrible hack to get a ref to the playlist model</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">187</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//FIXME: This is a horrible hack to get a ref to the playlist model</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you can remove this fixme</pre>
</div>
<br />
<p>- Bhushan Shah</p>
<br />
<p>On May 6th, 2014, 8:48 p.m. IST, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated May 6, 2014, 8:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When backends needed to access some PMC objects like the playlist model or register image providers, they used to fetch a reference to the view's declarative engine. This is risky because it exposes the view to the backends which can then do anything with it.
This patch adds a PmcRuntime class which serves as an official interface to these accesses cleanly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding songs to playlist, local pictures previews, local videos previews etc work fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/localfiles/localfilesabstractbackend.h <span style="color: grey">(2d47eba)</span></li>
<li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: grey">(b86a28a)</span></li>
<li>browsingbackends/localfiles/localpictures/localpicturesbackend.cpp <span style="color: grey">(f025c04)</span></li>
<li>browsingbackends/localfiles/localpictures/localpicturesmodel.h <span style="color: grey">(b1a81b4)</span></li>
<li>browsingbackends/localfiles/localpictures/localpicturesmodel.cpp <span style="color: grey">(c6b1816)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideosbackend.cpp <span style="color: grey">(8c20f27)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideosmodel.h <span style="color: grey">(e836c14)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideosmodel.cpp <span style="color: grey">(ab24013)</span></li>
<li>browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.h <span style="color: grey">(50af6c2)</span></li>
<li>browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp <span style="color: grey">(6991c97)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(f07d3ec)</span></li>
<li>libs/mediacenter/abstractbrowsingbackend.h <span style="color: grey">(537d00d)</span></li>
<li>libs/mediacenter/abstractbrowsingbackend.cpp <span style="color: grey">(eea4ee5)</span></li>
<li>libs/mediacenter/backendsmodel.h <span style="color: grey">(f98f60a)</span></li>
<li>libs/mediacenter/backendsmodel.cpp <span style="color: grey">(3a5fc30)</span></li>
<li>libs/mediacenter/pmcruntime.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/pmcruntime.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shells/newshell/mainwindow.h <span style="color: grey">(0aaa513)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(e369055)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118022/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>