<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118024/">https://git.reviewboard.kde.org/r/118024/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated May 6, 2014, 5:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Launcher menus traditionally offer an "Add to Panel" action for applications, which spawns an Icon applet in the relevant panel containment.
In the past, Containment::addApplet() had a QRect argument to set the initial applet position. Launchers like Kickoff and Homerun Kicker made use of this to try and insert the launcher icons to the left of the Task Manager widget, by providing a rect to the left of the middle of the containment, based on its geometry.
The equivalent Containment::createApplet() in Frameworks 5 no longer has this rect argument. The attached patch recreates this behavior inside the implementation of the Panel containment instead, by testing for the plugin name of the requested applet and inserting it before the applet at the center of the layout, if any - otherwise it falls back to the existing behavior of adding the applet before the last spacer or at the end of the layout.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>containments/panel/contents/ui/main.qml <span style="color: grey">(3dd531f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118024/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>