<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117983/">https://git.reviewboard.kde.org/r/117983/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e911838bd72f48dce8e8b45395d6f9069f657d91 by Shantanu Tushar to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On May 4th, 2014, 6:58 a.m. UTC, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated May 4, 2014, 6:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code around fetching/storing covers and other such images from remote sources and local files had become quite confusing over time. This patch removes unnecessary things and moves methods to the right places.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the following things-
* Album and Artist cover art
* Cover in MusicStats.qml when playing from a file
* Thumbnails in All Videos</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(1072799)</span></li>
<li>libs/mediacenter/pmccoverartprovider.h <span style="color: grey">(a4aeb83)</span></li>
<li>libs/mediacenter/pmccoverartprovider.cpp <span style="color: grey">(c68afa2)</span></li>
<li>libs/mediacenter/pmcimagecache.h <span style="color: grey">(631d5bd)</span></li>
<li>libs/mediacenter/pmcimagecache.cpp <span style="color: grey">(d1b57b5)</span></li>
<li>libs/mediacenter/pmcimageprovider.h <span style="color: grey">(e584810)</span></li>
<li>libs/mediacenter/pmcimageprovider.cpp <span style="color: grey">(4198f56)</span></li>
<li>libs/mediacenter/pmcmetadatamodel.cpp <span style="color: grey">(a58a57b)</span></li>
<li>libs/test/lastfmimagefetchertest.cpp <span style="color: grey">(b0fcf6f)</span></li>
<li>mediaelements/mediaplayer/MusicStats.qml <span style="color: grey">(178a37d)</span></li>
<li>mediaelements/popupmenu/PopupMenu.qml <span style="color: grey">(1c87926)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(764b228)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117983/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>