<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117884/">https://git.reviewboard.kde.org/r/117884/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding keditmimetype: I find it odd that KWidgetsAddons depends on a binary which is not provided by itself or by a component it depends on. Do we have other situations like this?
The "correct" solution would be to:
- Move keditmimetype from kde-cli-tools to KIO
- Move the KMimeTypeChooser class (the one which uses keditmimetype) from KWidgetsAddons to KIO
According to LXR KMimeTypeChooser is only used in KIO, so this change would work. The problem is this would break source compatibility, and now that we are close to the release date I don't think Kevin or David would allow that.</pre>
<br />
<p>- Aurélien Gâteau</p>
<br />
<p>On April 29th, 2014, 6:16 p.m. CEST, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated April 29, 2014, 6:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-cli-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">these cli tools are in kde-runtime in KDE 4 land so need to be renames so they are co-installable.
Many are unused in the KDE codebase according to lxr but some are used and I'll submit renaming patches to them if this is accepted..
keditfiletype used by:
frameworks/kio/src/widgets/kpropertiesdialog.cpp
frameworks/kwidgetsaddons/src/kmimetypechooser.cpp
applications/kde-baseapps/lib/konq/konq_operations.cpp
workspace/plasma-desktop/containments/folder/plugin/internallibkonq/konq_operations.cpp
workspace/plasma-desktop/kcms/componentchooser/componentchooserfilemanager.cpp
kmimetypefinder: unused
ktraderclient: used in
kde/workspace/kio-extras/kurifilter-plugins/tests/kurifiltertest.cpp
kioclient: used in
applications/kde-baseapps/konqueror/client/kfmclient.cpp
workspace/plasma-workspace/applets/devicenotifier/test-predicate-openinwindow.desktop
workspace/plasma-workspace/ksmserver/startup.cpp
workspace/plasma-workspace/drkonqi/data/mappings
kdecp: unused
kdemv: unused
kde-open: unused
ksvgtopng: unused
I note keditfiletype is used in frameworks so I should also look into moving that into a framework.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keditfiletype/CMakeLists.txt <span style="color: grey">(0adfde946b783cbee09661cfe445792eb1a54649)</span></li>
<li>kioclient/CMakeLists.txt <span style="color: grey">(cca4f5c222a3266f7ec468fa138bd2cefa880902)</span></li>
<li>kmimetypefinder/CMakeLists.txt <span style="color: grey">(720ccb07bd7a0a6a567b3bf70caa00d532232663)</span></li>
<li>kstart/CMakeLists.txt <span style="color: grey">(e7810d2788290b5f33447f90948dc020e1c8b1b9)</span></li>
<li>ksvgtopng/CMakeLists.txt <span style="color: grey">(82602887bb7370e591545b059418a68457c85c28)</span></li>
<li>ktraderclient/CMakeLists.txt <span style="color: grey">(028aac3ef9c5e293078df0796ee35577b0679afb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117884/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>