<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117923/">https://git.reviewboard.kde.org/r/117923/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>


<p style="color: grey;"><i>Updated May 1, 2014, 7:32 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Forgot to add libs/test/CMakeLists.txt in previous pacth</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently test is getting compiled along with libs. Due to this same source was compiled multiple times. With this patch, Plasma-medacenter creates a new plasmamediacentertest library which has default all exported symbols from libs. Now, test can be linked with libplasmamediacentertest.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Application runs as expected and all unit test passed</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/CMakeLists.txt <span style="color: grey">(a0a0f72)</span></li>

 <li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(2dbec83)</span></li>

 <li>libs/mediacenter/test/fakemediavalidator.h <span style="color: grey">(201973c)</span></li>

 <li>libs/mediacenter/test/fakemediavalidator.cpp <span style="color: grey">(9b2feca)</span></li>

 <li>libs/mediacenter/test/lastfmimagefetchertest.h <span style="color: grey">(6422824)</span></li>

 <li>libs/mediacenter/test/lastfmimagefetchertest.cpp <span style="color: grey">(b0fcf6f)</span></li>

 <li>libs/mediacenter/test/mediacentertest.h <span style="color: grey">(6997ae9)</span></li>

 <li>libs/mediacenter/test/mediacentertest.cpp <span style="color: grey">(96a70a9)</span></li>

 <li>libs/mediacenter/test/medialibrarytest.h <span style="color: grey">(718457d)</span></li>

 <li>libs/mediacenter/test/medialibrarytest.cpp <span style="color: grey">(08af239)</span></li>

 <li>libs/mediacenter/test/mediatest.h <span style="color: grey">(da16e59)</span></li>

 <li>libs/mediacenter/test/mediatest.cpp <span style="color: grey">(832fedb)</span></li>

 <li>libs/mediacenter/test/pmcmediatest.h <span style="color: grey">(2322176)</span></li>

 <li>libs/mediacenter/test/pmcmediatest.cpp <span style="color: grey">(0da8dd3)</span></li>

 <li>libs/mediacenter/test/singletonfactorytest.h <span style="color: grey">(79e4197)</span></li>

 <li>libs/mediacenter/test/singletonfactorytest.cpp <span style="color: grey">(308487d)</span></li>

 <li>libs/mediacenter/test/testhelpers.h <span style="color: grey">(9825e85)</span></li>

 <li>libs/test/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/fakemediavalidator.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/fakemediavalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/lastfmimagefetchertest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/lastfmimagefetchertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/mediacentertest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/mediacentertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/medialibrarytest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/medialibrarytest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/mediatest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/mediatest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/pmcmediatest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/pmcmediatest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/singletonfactorytest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/singletonfactorytest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/test/testhelpers.h <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117923/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>