<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117867/">https://git.reviewboard.kde.org/r/117867/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated April 30, 2014, 5:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We started caching results from media sources due to our primary data source (Nepomuk) was quite slow and the experience was quite bad both for fetching media and searching through it. Going forward, Baloo is our primary data source, and was found to be quite performant. Given this, the additional complexity of maintaining a cache in DB is too much for the 1-2 second increase in Media Library load times.
Note that we are still able to pull in data from multiple data sources, we just won't store it on disk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests pass, functionality works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>README <span style="color: grey">(be3e060)</span></li>
<li>cmake/FindQxOrm.cmake <span style="color: grey">(3c1fae1)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(32d45c2)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(809d2c0)</span></li>
<li>libs/mediacenter/album.h <span style="color: grey">(64b1205)</span></li>
<li>libs/mediacenter/album.cpp <span style="color: grey">(391a420)</span></li>
<li>libs/mediacenter/artist.h <span style="color: grey">(064aa02)</span></li>
<li>libs/mediacenter/artist.cpp <span style="color: grey">(6b32269)</span></li>
<li>libs/mediacenter/media.h <span style="color: grey">(830ad57)</span></li>
<li>libs/mediacenter/media.cpp <span style="color: grey">(a56a693)</span></li>
<li>libs/mediacenter/medialibrary.h <span style="color: grey">(8f9b5d3)</span></li>
<li>libs/mediacenter/medialibrary.cpp <span style="color: grey">(8f49c05)</span></li>
<li>libs/mediacenter/pmcalbum.h <span style="color: grey">(40c42fe)</span></li>
<li>libs/mediacenter/pmcartist.h <span style="color: grey">(f15a2e2)</span></li>
<li>libs/mediacenter/pmcmedia.cpp <span style="color: grey">(d94d6c7)</span></li>
<li>libs/mediacenter/precompiled.h <span style="color: grey">(73490b8)</span></li>
<li>libs/mediacenter/qxorm_export.h <span style="color: grey">(33fbf11)</span></li>
<li>libs/mediacenter/test/medialibrarytest.h <span style="color: grey">(2f8b476)</span></li>
<li>libs/mediacenter/test/medialibrarytest.cpp <span style="color: grey">(bb20a61)</span></li>
<li>libs/mediacenter/test/mediatest.h <span style="color: grey">(965bc7e)</span></li>
<li>libs/mediacenter/test/mediatest.cpp <span style="color: grey">(4f44334)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117867/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>