<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117800/">https://git.reviewboard.kde.org/r/117800/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the future, if you're doing a number of moves, you may want to generate the diff via --find-copies-harder</pre>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On April 29th, 2014, 9:39 a.m. UTC, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated April 29, 2014, 9:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doing so gives us two benefits-
1. We no longer have to export classes just to test them
2. We can use ORM mapped classes such as Artist, Album without extra magic for tests
(the diff shows deleted/new files because of the move, reviewing CMakeLists.txt changes should be sufficient)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, all unit tests pass</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/CMakeLists.txt <span style="color: grey">(59334e9)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(37769f6)</span></li>
<li>libs/mediacenter/lastfmimagefetcher.h <span style="color: grey">(4541c66)</span></li>
<li>libs/mediacenter/media.h <span style="color: grey">(2d6cc73)</span></li>
<li>libs/mediacenter/pmcimagecache.h <span style="color: grey">(d6d332e)</span></li>
<li>libs/mediacenter/subtitleprovider.h <span style="color: grey">(6f0d0f6)</span></li>
<li>libs/test/CMakeLists.txt <span style="color: grey">(52ec617)</span></li>
<li>libs/test/fakemediavalidator.h <span style="color: grey">()</span></li>
<li>libs/test/fakemediavalidator.cpp <span style="color: grey">(c2fdc17)</span></li>
<li>libs/test/lastfmimagefetchertest.h <span style="color: grey">()</span></li>
<li>libs/test/lastfmimagefetchertest.cpp <span style="color: grey">(9d06079)</span></li>
<li>libs/test/mediacentertest.h <span style="color: grey">()</span></li>
<li>libs/test/mediacentertest.cpp <span style="color: grey">(bb4c4d1)</span></li>
<li>libs/test/medialibrarytest.h <span style="color: grey">()</span></li>
<li>libs/test/medialibrarytest.cpp <span style="color: grey">(746d5b2)</span></li>
<li>libs/test/mediatest.h <span style="color: grey">()</span></li>
<li>libs/test/mediatest.cpp <span style="color: grey">(86ec0d0)</span></li>
<li>libs/test/pmcmediatest.h <span style="color: grey">()</span></li>
<li>libs/test/pmcmediatest.cpp <span style="color: grey">(4bdcae6)</span></li>
<li>libs/test/singletonfactorytest.h <span style="color: grey">()</span></li>
<li>libs/test/singletonfactorytest.cpp <span style="color: grey">(b9fc987)</span></li>
<li>libs/test/testhelpers.h <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117800/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>