<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117542/">https://git.reviewboard.kde.org/r/117542/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 24th, 2014, 9:33 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Screenshots?
My main question is: Is this going to fit into the new systemtray? The popup is not resizable, so it might push out part of the UI underneath.</pre>
</blockquote>
<p>On April 24th, 2014, 9:38 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">... which is really unfortunate.
However, I will drop the Serial number thing as well as manufacturer/model if it's already clear from the displayed battery name, ie. There's no point in displaying "Logitech Trackball, manufacturer: Logitech".</pre>
</blockquote>
<p>On April 24th, 2014, 10:08 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's a regression, which will be fixed later. Just pushing in new things that will make it appear more broken is not smart.
I'd rather exclude the extra information, in fact I'd rather not make the thing expandable at all -- i.e. remove the information. I've this slight suspicion that you don't like this suggestion, though. ;)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, I was thinking of it myself :-)
Would a tooltip work? I think the capacity is a rather interesting piece of information ("oh my battery lasts only half an hour why is that?"). For the other things not so much.
Oh and speaking of improving the battery monitor: I do get two icons (battery+mouse) cramped into the square space of a single icon in systray as iirc there are no means of checking if the battery monitor is constrained in a panel or at least it's broken(?)</pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On April 13th, 2014, 1:45 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated April 13, 2014, 1:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds the following improvements provided by Review 117339 and Review 117540:
- Show temperature, voltage, energy rate and serial number. Since those are only shown when expanding the battery it's imho not that bad to show some geeky stuff which can give you some more indication of battery health and overall power consumption. It adds new strings, however. It also changes the substr hackery to "enabled: false" for greying out the labels.
What's the preferred way of formatting numbers (decimal points, units)? The formats thing only seems to be for file sizes and durations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles. Information is properly displayed when expanding a battery.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/batterymonitor/contents/code/logic.js <span style="color: grey">(5b4cb52)</span></li>
<li>applets/batterymonitor/contents/ui/BatteryItem.qml <span style="color: grey">(431aa9a)</span></li>
<li>applets/batterymonitor/contents/ui/CompactRepresentation.qml <span style="color: grey">(39cd331)</span></li>
<li>applets/batterymonitor/contents/ui/DetailsLabel.qml <span style="color: grey">(d973d22)</span></li>
<li>applets/batterymonitor/contents/ui/PopupDialog.qml <span style="color: grey">(0444199)</span></li>
<li>applets/batterymonitor/contents/ui/batterymonitor.qml <span style="color: grey">(4711c5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117542/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>