<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117691/">https://git.reviewboard.kde.org/r/117691/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 23rd, 2014, 11:08 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems to be an ulra-hack, but if it works, i guess you should commit it if it really helps your users to be able to use your product.
Maybe adding a big "TODO" somewhere to recheck if this is needed later on or something.</pre>
</blockquote>
<p>On April 24th, 2014, 5:28 a.m. UTC, <b>Shantanu Tushar</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Our current release is 1.2 and 1.3 will be released in June, these two will need this hack. After that we will move to a Qt5/KF5 port where we will not need this.
I was also wondering if instead of actually committing this to the repo, we just keep this as a patch for distros to apply. Thoughts?</pre>
</blockquote>
<p>On April 24th, 2014, 5:32 a.m. UTC, <b>Bhushan Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I was also wondering if instead of actually committing this to the repo, we just keep this as a patch for distros to apply. Thoughts?
+1, Also if possible some CMake option which enable plasmaadapter, so that they don't have to patch but just add cmake flag during configure.</pre>
</blockquote>
<p>On April 24th, 2014, 11:27 a.m. UTC, <b>Sujith Haridasan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I too agree with Shantanu Tushar.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I also think adding switch in CMake will be better rather than keeping as a patch.</pre>
<br />
<p>- Sinny</p>
<br />
<p>On April 22nd, 2014, 7:53 p.m. UTC, Sinny Kumari wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Albert Astals Cid.</div>
<div>By Sinny Kumari.</div>
<p style="color: grey;"><i>Updated April 22, 2014, 7:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In Kubuntu 14.04 release, we found that Plasma Media Center was unable to play video/audio files. Reason behind it was PMC was linking with libplasma and QtMultimediaKit. libplasma links with libgstreamer1.0 while QtMultimediaKit links with libgstreamer0.10.
This patch loads libplasma and unloads it after we are done as suggested on http://lists.kde.org/?l=kde-devel&m=139811564632441&w=2 .</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Able to play audio/video on Kubuntu 14.04 and Fedora 19. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaadapter/plasmaadapter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/plasmaadapter/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(7e0a9aa)</span></li>
<li>shells/newshell/CMakeLists.txt <span style="color: grey">(9d9ea29)</span></li>
<li>shells/newshell/mainwindow.h <span style="color: grey">(eb2b276)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(9735a0a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117691/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>