<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117632/">https://git.reviewboard.kde.org/r/117632/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 24th, 2014, 9:05 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117632/diff/4/?file=267934#file267934line87" style="color: black; font-weight: bold; text-decoration: underline;">plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">anchors.bottomMargin:</span> <span class="nx">konsolePreviewer</span><span class="p">.</span><span class="nx">height</span> <span class="o">/</span> <span class="mi">10</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">units.largeSpacing / 2
seems better here. Using konsolePreviewer.height seems rather random to me.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have upload two screenshots. the first one with units.largeSpacing / 2
and the second one with units.largeSpacing / 4. I find that the "/4" is better.
What do you think?</pre>
<br />
<p>- Antonis</p>
<br />
<p>On April 24th, 2014, 10:21 a.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated April 24, 2014, 10:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch enables the konsole and it fixes the spacing.
More info on the screenshots.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <span style="color: grey">(c3624a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117632/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/8e659a10-f238-440f-b10a-90533880dc99__konsole_spacing-wrong.png">before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/c9bb85d3-4f8e-4b9c-bbbf-bc80f7ccf71b__konsole_spacing-ok.png">after</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/e019b5ab-ec1b-453d-a730-ac13d60b4c74__konsole_spacing.png">units.largeSpacing/2</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/0793b296-9490-47a6-8d43-f3c3653201f4__konsole_spacing_units_large.png">units.largespacing/4</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>