<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117417/">https://git.reviewboard.kde.org/r/117417/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 084d81346f67dd0cb9478bc5aa606481d7873d46 by Martin Gräßlin to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On April 7th, 2014, 9:09 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 7, 2014, 9:09 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[ksmserver/screenlocker] Port the locker library away from kde4support
[ksmserver/screenlocker] KApplication -> QApplication
[ksmserver/screenlocker] kDebug -> qDebug
[ksmserver/screenlocker] Drop usage of KDialog
Not really needed.
[ksmserver/screenlocker] Hard-code path to screenlocker_greet
Porting away from KStandardDirs. As it used to be libexec it's now hard
coded through the config-ksmserver.h.cmake.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only compile tested so far as it needs restarting ksmserver.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/config-ksmserver.h.cmake <span style="color: grey">(2ad0394a10c0720b02c87a7399641619e819d907)</span></li>
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: grey">(9aeec778c58686b4cac8c139dade00a57f69e999)</span></li>
<li>ksmserver/screenlocker/autologout.cpp <span style="color: grey">(2a5eaf266eaf65a93b8cbf59eec45f9d2d536f82)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(c2db0425d87737a0052792f763737a2a2ec96f18)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: grey">(5ca93a6075c5fa4b34ac84cd293e99044cc18df0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117417/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>