<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117450/">https://git.reviewboard.kde.org/r/117450/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 10th, 2014, 11:16 a.m. CEST, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so, right now we already have two search uis added by default in the default setup: kickoff and krunner.
adding a 3rd one by default, just no.
what should be done is having the milou search ui into the kickoff search (and/or whoever will replace it in the future)</pre>
</blockquote>
<p>On April 10th, 2014, 11:20 a.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just want to say that I think in the same line as Marco here.</pre>
</blockquote>
<p>On April 10th, 2014, 11:49 a.m. CEST, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The way I see it we currently have 2 hidden ways of searching.
Kick off - It's not obvious that you can starting typing and that will give search results.
KRunner - You need to know the shortcut
Also, the quality/presentation of the search results in quite different in Kick Off in comparison to KRunner / Milou.
I don't see the Milou Search UI going into KickOff. It presents data very differently than how Milou displays stuff, it would look quite strange.</pre>
</blockquote>
<p>On April 11th, 2014, 10:57 p.m. CEST, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I very much like the idea of having Milou added there by default.
Yea sure, we have kickoff and krunner. Kickoff is not at all intuitive when it comes to searching. I just avoid using it when i can. Sometimes i even remove kickoff and put some other menu widget there. Milou looks very much like an application suitable for todays search needs. Nice and grouped. KRunner is missing that overview.
Perhaps remove krunner while making Milou the default?
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My concern is more on how the users will see it. Will they understand that Milou and Kickoff work differently or will they think that we ship redundant features by default? So yes they serve a different purpose, but from an end user perspective I rather doubt it.</pre>
<br />
<p>- Martin</p>
<br />
<p>On April 9th, 2014, 5:22 p.m. CEST, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated April 9, 2014, 5:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KRunner is hidden away as it is only accessible via a shortcut. It will be nice to have the plasmoid visible by default. It will not be an extra dependency as plasma-workspace already depends on Milou because of KRunner.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/layout.js <span style="color: grey">(303e7af)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117450/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>