<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117464/">https://git.reviewboard.kde.org/r/117464/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> This means the notification right now has nothing more than debug purpose.
Wasn't there some accessibility reason for that notification? Because you can also have audio notification and others (custom plugins to KNotifications), not just popups.</pre>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On April 10th, 2014, 8:20 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez and Aurélien Gâteau.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 10, 2014, 8:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[kglobalaccel] Remove notification support
KGlobalAccel emitted notifications when:
* a shortcut is pressed
* a new shortcut is registered
Both are configured with no action at all. Thus the notification is not
of much use. Why it shouldn't show a popup had been discussed on kcd [1].
This means the notification right now has nothing more than debug
purpose. While this might be a valid usecase it doesn't make much sense
to do this with KNotification - for this see Aaron's mail [2]. Also e.g.
KWin dropped all notifications for debug purposes for the same reason.
If there is a need for a kind of notification on global shortcut
triggered or a new registered global shortcut this could also be easily
emulated by adding an explicit signal to the DBus interface.
This removes the KNotificiation dependency.
[1] http://lists.kde.org/?t=126463249400002&r=1&w=2&n=16
[2] http://lists.kde.org/?l=kde-core-devel&m=126463340225306&w=2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kglobalaccel/CMakeLists.txt <span style="color: grey">(b77f85edab091fd260fb9bddb1ddb43df445c5fe)</span></li>
<li>kglobalaccel/globalshortcutsregistry.cpp <span style="color: grey">(41a351b47a66c24f2e25d0d0d1df9c8a9b6616ef)</span></li>
<li>kglobalaccel/kglobalaccel.notifyrc <span style="color: grey">(aec41137180c18a89e21a537b9e73da715b5f55d)</span></li>
<li>kglobalaccel/kglobalacceld.h <span style="color: grey">(cb058acd0e1d50c47f3cab0cd9e0a061fd0d7a67)</span></li>
<li>kglobalaccel/kglobalacceld.cpp <span style="color: grey">(86d54695a4b75dc20b46ba4c9ada398d96093a53)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117464/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>