<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117447/">https://git.reviewboard.kde.org/r/117447/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 9th, 2014, 11:27 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like the idea, only two things:
* I am not sure about the default, would rather have it empty so everybody that doesn't set it goes in a "misc" section
* if this goes in, i would like to see sprinter's querymatch have the same, to avoid "oh crap" moments when porting</pre>
</blockquote>
<p>On April 9th, 2014, 11:29 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(is pretty much corresponding to matchtype in sprinter if i understood correctly?)</pre>
</blockquote>
<p>On April 9th, 2014, 11:55 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">About the default, we discussed it a bit shortly and it seems like runners are _never_ sharing categories. If we haven't found a use-case yet, I wouldn't expect it to happen now.
Creating a shared misc category sounds artificial to me.
</pre>
</blockquote>
<p>On April 9th, 2014, 12:01 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm, i can easily think about different runners returning website urls, or resutls of type "video" regardless if is a search on the filesystem or from a youtube runner..</pre>
</blockquote>
<p>On April 9th, 2014, 12:23 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* I like the idea of having a sensible default. A Misc section sounds ugly. Plus this means we only need to patch a few runners (services and Baloo)
Sprinter has a MatchType which is an enum. I tried doing the same thing originally but I could not figure out how how to map most of the runners we have - Solid / Recent Documents / Places / etc. When someone decides to write a UI for Sprinter, they will encounter the same issue. They currently group "Recent Documents" as "Files", and "Places" as "FileSystemLocation".
@Marco: I do not think that the "Youtube" videos should be grouped under the same "Videos" category for the videos files in your filesystem. We need to give some distinction between local videos and external videos.</pre>
</blockquote>
<p>On April 10th, 2014, 9:11 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmm, to me a video is a video..
by default all the remote queries should of course be disabled, but if i explicitly enabled them, then i don't care where the video comes from.. i would probably care having all local videos coming before the remote ones, but they are still just videos</pre>
</blockquote>
<p>On April 10th, 2014, 9:56 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes they are all just videos, but the user needs to be given context as to where the data comes from. One cannot just interleave youtube videos + vimeo videos + local videos.
We also have to take our UI into consideration - We can at max display 3-6 results of each category[1]. If we interleave web searches + local searches, then the web-searches will almost never be shown. The local results will be faster than the web results.
[1] depends on the number of categories</pre>
</blockquote>
<p>On April 10th, 2014, 10:24 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe we should have a discussion separately regarding remote vs local? I think it hasn't been discussed and I'm afraid it would cause misunderstandings in the future.
Regarding the actual patch, I don't think it would be bad to have a "YouTube" category.</pre>
</blockquote>
<p>On April 10th, 2014, 10:46 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">only thing i fear about having categories as strings is the complete lack of standardization, that will bring things like categories
"pictures" "images" "photos"
"music" "audio" "mp3" "songs"
"remote" "internet" "cloud" "services" "online"
I would really prefer as few categories as possible even if not "technically precise" than a load of random names each author of a runner came up, each one different
</pre>
</blockquote>
<p>On April 10th, 2014, 10:58 a.m. UTC, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In Sprinter you can define the type and the source of each match.
e.g. youtube sprinter-plugin:
Sprinter::QueryMatch match;
match.setTitle(tr("%1 (%2, %3)").arg(title, author, time));
match.setType(Sprinter::QuerySession::VideoType);
match.setSource(Sprinter::QuerySession::FromNetworkService);
And I completely agree with Marco, a video is a video independent from the source it comes from.</pre>
</blockquote>
<p>On April 10th, 2014, 11:08 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">about having too many results per category..
this is clearly a visualization issue more than a model related one.
one solution may be (given that each category has a really reliable prioritization of results) to show a max of results per category, say 10 or so, plus a "more" item as the last, and then it goes in a second page where it shows all the results for a given category, and only that category.
or i don't know, there may be other ;)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding Standardization - We have a limited number of runners, most of which currently do NOT require categories.
Regarding this patch: We can either have this simple category implementation or implement all of this type + source + others which Sprinter provides. Considering that KRunner is going to be deprecated, I rather not do that. Additionally it will make the Milou code quite complicated as well.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On April 9th, 2014, 11:18 a.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aleix Pol Gonzalez.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated April 9, 2014, 11:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
krunner
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">
This string based category is useful in categorizing the results. By
default the category defaults to the name of the runner.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/querymatch.h <span style="color: grey">(afec76e)</span></li>
<li>src/querymatch.cpp <span style="color: grey">(83888f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117447/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>