<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117324/">https://git.reviewboard.kde.org/r/117324/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added the wrong REVIEW tag to the commit: submitted with 447703ee86fa5f4751e7089cb9ab3976ede952a8</pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On April 7th, 2014, 8:13 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Àlex Fiestas, David Edmundson, and Kirill Elagin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 7, 2014, 8:13 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=314989">314989</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add logind integration to screenlocker
A new class LogindIntegration is added to the screenlocker. This class
listens to the Lock and Unlock signals emitted by the session object on
the logind service.
This is integrated with the screenlocker application to start or quit the
lock when the signals are emitted. This means a locked screen is unlocked
when the Unlock signal is received from logind. Logind is a higher
authority for the screenlocker and thus follows the requests from logind.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so far only tested with the unit test. Still need to restart the session.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/autotests/logindtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/autotests/fakelogind.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/autotests/fakelogind.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: grey">(55ebc6f)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(f2e5262)</span></li>
<li>ksmserver/screenlocker/logind.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/logind.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117324/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>