<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117359/">https://git.reviewboard.kde.org/r/117359/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you create the patch with --find-copies-harder? It will be much easier to review.
</pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On April 3rd, 2014, 3:31 p.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Àlex Fiestas.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated April 3, 2014, 3:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">import phonon KCM and phonon platform plugin
- both ported away from deprecated classes
- the kcm additionally had a cleanup of phonon private header copies
- backendselection in the KCM was ported to a native Qt solution for
phonon4qt5
- the platform plugin has just about all pointless features removed leading
up to what may (or may not) be a platform plugin in a future phonon5 API
- all direct ALSA handling was removed (e.g. the kded phononserver), we
prefer PulseAudio device control over anything else, and short of that
we'll expect the actual backend to provide a list of possible outputs
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- build & install
- kcm change device order & change backend order</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>phonon/kcm/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(28ad201)</span></li>
<li>phonon/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/phononbackend.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/phonon.notifyrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/kiomediastream_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/kiomediastream.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/kiomediastream.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/kdeplatformplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/kdeplatformplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/debug.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/platform_kde/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/testspeakerwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/testspeakerwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/main.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/listview-background.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/kcm_phonon.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/devicepreference.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/devicepreference.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/devicepreference.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/backendselection.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/backendselection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/backendselection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/audiosetup.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/audiosetup.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/kcm/audiosetup.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117359/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>