<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117321/">https://git.reviewboard.kde.org/r/117321/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 95bf51b90edb3946541696da62e431e63abbc9a1 by Martin Gräßlin to branch master.</pre>
 <br />









<p>- Commit Hook</p>


<br />
<p>On April 2nd, 2014, 6:29 a.m. UTC, Martin Gräßlin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>


<p style="color: grey;"><i>Updated April 2, 2014, 6:29 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add password checking to screenlocker
    
A new Authenticator item is introduced and exported to QML. It provides
a slot tryAuthenticate taking the password as a string. If invoked it
creates a KCheckPass object which handles the communication with the
kcheckpass binary to verify the password. If the authentication succeeded
the Authenticator emits a succeeded() signal, on failure a failed()
signal.

The authentication process is bound to a grace timer. While this timer is
active it's not possible to authenticate again. This state is exposed
with a Q_PROPERTY and used by the UI to disable the password field and
unlock button.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/config-ksmserver.h.cmake <span style="color: grey">(4b60c8c)</span></li>

 <li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: grey">(53fe38b)</span></li>

 <li>ksmserver/screenlocker/greeter/authenticator.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>ksmserver/screenlocker/greeter/authenticator.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>ksmserver/screenlocker/greeter/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>ksmserver/screenlocker/greeter/autotests/fakekcheckpass.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: grey">(7a84bb4)</span></li>

 <li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(496c012)</span></li>

 <li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml <span style="color: grey">(7aa59f8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117321/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>