<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117041/">https://git.reviewboard.kde.org/r/117041/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Sebastian Kügler.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated April 1, 2014, 8:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Sebastian,
Dominik suggested that you might give input to this review request.
The code is now at a "shipitable" state. Maybe one of you core plasma guys could confirm that. There is one minor issue, though:
When unchecking (and only then) the new "Restrict width on large host panel" checkbox the applet size is not updated until a resize event occurs. The other way round (checking the checkbox) it works well (applet width -- or height -- is immediately restricted). So if you see how to fix this at once that would be appreciated. If it would consume too much time to find the cause, it won't hurt to leave it like it is since in the end all applets should be ported to QML anyway.
Thanks & Best regards</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Summary
-------
Add two options:
1. Show confirmation before sending (to prevent accidental sending of maybe sensible data)
2. Appearance: Restrict width on large host panel (to prevent huge icon on large panels)
How does this change manifest on screen?
----------------------------------------
Settings dialog:
- before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
- after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
Behaviour:
1. "Show confirmation before sending" turned on and after dropping an image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
2. "Appearance: Restrict width on large host panel"
- turned off (default): http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to other icons in system tray)
- turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is restricted so it does not eat up horizontal space)
Open issues
-----------
- Is there a default "review board TARGET_GROUP" for kdeplasma-addons review-request?
@apol: I saw that in the frameworks branch you replaced pastebin with quickshare. I haven't had the chance to test it out. Does it already have the same features as pastebin?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See screenshots in description. Test if settings are getting stored. Test with different form factors (horizontal, vertical).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/pastebin/pastebinConfig.ui <span style="color: grey">(540fae733c0ea738b48b3bf2b11b9f9b10bdb453)</span></li>
<li>applets/pastebin/pastebin.cpp <span style="color: grey">(df7f534c17d5a383480f385b83948d01635641a7)</span></li>
<li>applets/pastebin/pastebin.h <span style="color: grey">(931057f9df4f5e875f3984df1f40869235d8297e)</span></li>
<li>.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117041/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>