<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116722/">https://git.reviewboard.kde.org/r/116722/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 11th, 2014, 3:57 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oddly is exactly the patch that i was trying yesterday ;)
one thing i found out tough: item->window() of course is not aways there (for instance whenthe item is in a Dialog that hasn't been shown yet)
so in many cases this won't work.
I wonder if it may be made a bit more complex keeping the item and connecting to windowChanged() to update the window in case is a qquickItem?
(and in any way it becomes, the corresponding settransientparent in Dialog should also be made behave the same)</pre>
</blockquote>
<p>On March 11th, 2014, 4:01 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you remember the use case where this didn't work?</pre>
</blockquote>
<p>On March 11th, 2014, 4:05 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in https://bugs.kde.org/show_bug.cgi?id=331931
the first time window() is 0
from the second time you open the popup onwards, that's fine</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK. I'll claim that bug and I'll check if I fix that. Updating this if need be.
Thanks.</pre>
<br />
<p>- David</p>
<br />
<p>On March 11th, 2014, 3:52 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 11, 2014, 3:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow setTransientParent from an item
Because QWindow is not exposed as a property of Item in certain cases we
may not have access to the owning window in a qml that has menus. For
example WidgetExplorer.
This patch also fixes crash in setTransientParent is called before a window is set on
the menu.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qmenu.h <span style="color: grey">(d1a5b73)</span></li>
<li>src/declarativeimports/plasmacomponents/qmenu.cpp <span style="color: grey">(a9b41a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116722/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>