<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116648/">https://git.reviewboard.kde.org/r/116648/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 7th, 2014, 3:15 p.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Martin,
Any idea why the background behind the shells is flat ? Does it happend with all KCMs ?
(I'll double check asap but right now my systemsettings is crashing because my kauth is fubared. Links against incorrect pluggin, and qt4 and blows)</pre>
</blockquote>
<p>On March 7th, 2014, 3:18 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Known QML issue (at least I bet this is)</pre>
</blockquote>
<p>On March 7th, 2014, 3:19 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">clearly QtQuick issue</pre>
</blockquote>
<p>On March 7th, 2014, 3:31 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes and no.
We're quite clearly hardcoding a solid background colour here:
Rectangle {
color: engine.backgroundViewColor()
}
If QtQuickControls was working it wouldn't fix that.
But QtQuickControls doesn't handle the radial background yet, so it's kinda a moot point.
It /might/ be possible to not set a background here, and set the QQuickView QWindow to be transparent and we'd see the radial background of the underlying KCM QWidget?
</pre>
</blockquote>
<p>On March 7th, 2014, 3:41 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to the findings in some other RR: no.
QtQuick/QML is designed to be some scene (graph driven) and esp. if it uses HW acceleration, merging in the widget backingstore should pretty much defeat that approach - a solution in that direction (even on top of a Q*View patch) should be pretty "ugly" (rendering all widgets below into an image and importing that as background - needs to be redone whenever there's a paint event on any of the covered widgets)
Also this cannot be resolved by hardcoding some gradient (then matching oxygen, but breaking plastique or qtcurve whch can have any random texture/watermark ...)</pre>
</blockquote>
<p>On March 10th, 2014, 9:54 a.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Naive question: since QtQuick/QML seems to have limitations, is there a reason for using QML in the compositor kcm, over widgets and ui files, that would not show the issue ? In the past I though using QML inside widgets was discouraged (but maybe this changed, or I missunderstood at that time) ?
Also, I remember AFiestas patching both oxygen and some kde qml elements in order to pass some hints to the style so that things are rendered properly. I have no clue if doable at all (and maybe Alex should be cced here), but could a similar thing be done here to get proper background rendering ? (I can send to the relevant oxygen review requests if needed)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">... sorry. That was actually Martin Klapetek
See commit "860401fb393985877573bf136c2d317193da62b9" for instance</pre>
<br />
<p>- Hugo</p>
<br />
<p>On March 10th, 2014, 9:03 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin, Plasma and Antonis Tsiapaliokas.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 10, 2014, 9:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin-compositing-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split into one KCM for Desktop Effects and one for Compositing
Let's try getting the KCM a little bit less scary by properly
hiding everything the user doesn't have to care about. The prominent
desktop effects KCM only contains the list of all the effects which
can be configured and nothing else. Only exception is the disabled
check after failed GL to make this easier for the user.
All the "advanced" settings are moved into a new KCM called
"Compositing" which is put under the hardware component in
systemsettings. This contains all advanced settings including
* whether compositing is enabled at all
* backend
* animation speeed
* scale filter
* unredirect fullscreen
* color correction</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d70672f3937fb44240c2c2d8e2a8d90c67890e2a)</span></li>
<li>kcmkwineffects.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwincompositing.desktop <span style="color: grey">(88ecf46b393df947d6b59ce53c924a82fc65756a)</span></li>
<li>main.cpp <span style="color: grey">(5c68722961be9b8a0a48f3221df7c033ba3cf946)</span></li>
<li>model.h <span style="color: grey">(2efa2a9df63ee7f7ec483df004ff9530fdc0f852)</span></li>
<li>model.cpp <span style="color: grey">(2b25fe04ccacf0fb719956b1b5fa0267611747e6)</span></li>
<li>qml/CompositingView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/EffectView.qml <span style="color: grey">(c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2)</span></li>
<li>qml/OpenGLErrorView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/main-compositing.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/main.qml <span style="color: grey">(d22dd08da529df938d99ff9d43f52f7b33a7f2d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116648/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png">New advanced compositing KCM</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png">New effects KCM</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/f467b643-5341-4cfe-8282-eeea93bc98e5__kcmeffects.png">Effects KCM with GHNS button</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/10/70df036e-f3ad-455d-a323-c8f36220afd4__kcmcompositing.png">Latest kcmcompositing screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>