<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116648/">https://git.reviewboard.kde.org/r/116648/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/116648/file/1105/" style="color: black; font-weight: bold; font-size: 9pt;">kcmcompositing.png</a>
<p>Latest kcmcompositing screenshot</p>
<div><img src="" width="149" height="43" alt="Would this rather belong into the FX kcm?" /></div>
</td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would this rather belong into the FX kcm?</pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/116648/file/1105/" style="color: black; font-weight: bold; font-size: 9pt;">kcmcompositing.png</a>
<p>Latest kcmcompositing screenshot</p>
<div><img src="" width="229" height="31" alt="acceptable to remove this from the for layout (and put on top and a splitter below?)" /></div>
</td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">acceptable to remove this from the for layout (and put on top and a splitter below?)</pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/116648/file/1105/" style="color: black; font-weight: bold; font-size: 9pt;">kcmcompositing.png</a>
<p>Latest kcmcompositing screenshot</p>
<div><img src="" width="49" height="43" alt="If "enable on startup" can be put outside, those could be moved to the bottom ("experimental" option 3rd does not sound very promising and unredirection is the problematic unsuggested thing)" /></div>
</td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If "enable on startup" can be put outside, those could be moved to the bottom ("experimental" option 3rd does not sound very promising and unredirection is the problematic unsuggested thing)</pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/116648/file/1105/" style="color: black; font-weight: bold; font-size: 9pt;">kcmcompositing.png</a>
<p>Latest kcmcompositing screenshot</p>
<div><img src="" width="140" height="21" alt="Scale method and vsync are backend dependent, so i'd move this below the two (resp. them right below the backend)" /></div>
</td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Scale method and vsync are backend dependent, so i'd move this below the two (resp. them right below the backend)</pre>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On March 10th, 2014, 9:03 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin, Plasma and Antonis Tsiapaliokas.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 10, 2014, 9:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin-compositing-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split into one KCM for Desktop Effects and one for Compositing
Let's try getting the KCM a little bit less scary by properly
hiding everything the user doesn't have to care about. The prominent
desktop effects KCM only contains the list of all the effects which
can be configured and nothing else. Only exception is the disabled
check after failed GL to make this easier for the user.
All the "advanced" settings are moved into a new KCM called
"Compositing" which is put under the hardware component in
systemsettings. This contains all advanced settings including
* whether compositing is enabled at all
* backend
* animation speeed
* scale filter
* unredirect fullscreen
* color correction</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d70672f3937fb44240c2c2d8e2a8d90c67890e2a)</span></li>
<li>kcmkwineffects.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwincompositing.desktop <span style="color: grey">(88ecf46b393df947d6b59ce53c924a82fc65756a)</span></li>
<li>main.cpp <span style="color: grey">(5c68722961be9b8a0a48f3221df7c033ba3cf946)</span></li>
<li>model.h <span style="color: grey">(2efa2a9df63ee7f7ec483df004ff9530fdc0f852)</span></li>
<li>model.cpp <span style="color: grey">(2b25fe04ccacf0fb719956b1b5fa0267611747e6)</span></li>
<li>qml/CompositingView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/EffectView.qml <span style="color: grey">(c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2)</span></li>
<li>qml/OpenGLErrorView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/main-compositing.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/main.qml <span style="color: grey">(d22dd08da529df938d99ff9d43f52f7b33a7f2d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116648/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png">New advanced compositing KCM</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png">New effects KCM</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/f467b643-5341-4cfe-8282-eeea93bc98e5__kcmeffects.png">Effects KCM with GHNS button</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/10/70df036e-f3ad-455d-a323-c8f36220afd4__kcmcompositing.png">Latest kcmcompositing screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>