<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116620/">https://git.reviewboard.kde.org/r/116620/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2014, 8:01 a.m. UTC, <b>Shantanu Tushar</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After going to playlist like this, if you press back you get a blank screen with Loading spinner. Expected is the homescreen to come back.</pre>
</blockquote>
<p>On March 6th, 2014, 8:10 a.m. UTC, <b>Ashish Madeti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1.Start PMC
2.Click on empty area (playlist shows)
3.Click back.
I am getting homescreen only after step 3.
Am I missing something here ?</pre>
</blockquote>
<p>On March 6th, 2014, 11:01 a.m. UTC, <b>Shantanu Tushar</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm I tried your patch again and I still get the empty screen. It might be local to me, you should wait for someone else to confirm this works.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok this was not due to your patch, it was an unrelated bug that I have now fixed. So your patch works fine now.</pre>
<br />
<p>- Shantanu</p>
<br />
<p>On March 6th, 2014, 5:20 a.m. UTC, Ashish Madeti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.</div>
<div>By Ashish Madeti.</div>
<p style="color: grey;"><i>Updated March 6, 2014, 5:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820
Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller.
If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to :
pmcPageStack.pushAndFocus(getPlaylist());</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area.
2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: grey">(49ea403)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116620/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>