<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116596/">https://git.reviewboard.kde.org/r/116596/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116596/diff/2/?file=251976#file251976line135" style="color: black; font-weight: bold; text-decoration: underline;">mediaelements/playlist/Playlist.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">135</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">onTriggered:</span> <span class="nx">playlistList</span><span class="p">.</span><span class="nx">positionViewAtIndex</span><span class="p">(</span><span class="nx">playlistList</span><span class="p">.</span><span class="nx">currentIndex</span><span class="p">,</span> <span class="nx">ListView</span><span class="p">.</span><span class="nx"><span class="hl">Center</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">135</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">onTriggered:</span> <span class="nx">playlistList</span><span class="p">.</span><span class="nx">positionViewAtIndex</span><span class="p">(</span><span class="nx">playlistList</span><span class="p">.</span><span class="nx">currentIndex</span><span class="p">,</span> <span class="nx">ListView</span><span class="p">.</span><span class="nx"><span class="hl">Visible</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I suggest using ListView.Contain instead.</pre>
</div>
<br />
<p>- Shantanu Tushar</p>
<br />
<p>On March 4th, 2014, 7:28 p.m. UTC, Ashish Madeti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.</div>
<div>By Ashish Madeti.</div>
<p style="color: grey;"><i>Updated March 4, 2014, 7:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168
Now not only can you delete the media without playing it, it is easier to navigate the playlist then before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1.Deleted a song from a playlist without playing it.
2.Traversed the playlist without using keyboard or mouse scroll button.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/playlist/Playlist.qml <span style="color: grey">(fd83c21)</span></li>
<li>mediaelements/playlist/PlaylistDelegate.qml <span style="color: grey">(e1bd31d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116596/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>