<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115952/">https://git.reviewboard.kde.org/r/115952/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and David Stephen Hubner.</div>
<div>By Martin Gräßlin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[kinfocenter] Add support for OpenGL running on Wayland
The X11 specific code is only executed on xcb platform. For detecting
OpenGL on Wayland we don't do the native calls ourself, but use Qt
functionality. We know that on Wayland Qt will use egl, so to simplify
we can just use an QOpenGLContext. That code would also work for xcb,
but Qt uses either glx or egl compile time switched, so it's easier to
just keep the existing and working glx and egl implementation for X11.
As Qt makes it easy to request both core and compatibility profile we
try all of that:
* normal (nothing specified)
* core
* compatibility
The X11 code should also be extended in that direction. Unfortunately
I couldn't test it as the mesa version I'm currently running is only
providing OpenGL 3.0.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kinfocenter/Modules/opengl/opengl.cpp <span style="color: grey">(601337f071452eca7a3add127e8e1ff1586bbef0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115952/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/22/49469470-c14a-4b76-b476-e291497452df__kinfocenter-gl-wayland.png">OpenGL module on Wayland</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>